| Message ID | 20210929025847.646999-1-ipylypiv@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] scsi: pm80xx: Replace open coded check with dev_is_expander() | expand |
On Wed, Sep 29, 2021 at 4:58 AM Igor Pylypiv <ipylypiv@google.com> wrote: > > pm8001_mpi_get_nvmd_resp() handles a GET_NVMD_DATA response, not > a SET_NVMD_DATA response, as the log statement implies. > > Fixes: 1f889b58716a ("scsi: pm80xx: Fix pm8001_mpi_get_nvmd_resp() > race condition") > > Reviewed-by: Changyuan Lyu <changyuanl@google.com> > Signed-off-by: Igor Pylypiv <ipylypiv@google.com> Acked-by: Jack Wang <jinpu.wang@ionos.com> > --- > drivers/scsi/pm8001/pm8001_hwi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c > index b73d286bea60..69e5f3db336b 100644 > --- a/drivers/scsi/pm8001/pm8001_hwi.c > +++ b/drivers/scsi/pm8001/pm8001_hwi.c > @@ -3169,7 +3169,7 @@ pm8001_mpi_get_nvmd_resp(struct pm8001_hba_info *pm8001_ha, void *piomb) > * fw_control_context->usrAddr > */ > complete(pm8001_ha->nvmd_completion); > - pm8001_dbg(pm8001_ha, MSG, "Set nvm data complete!\n"); > + pm8001_dbg(pm8001_ha, MSG, "Get nvmd data complete!\n"); > ccb->task = NULL; > ccb->ccb_tag = 0xFFFFFFFF; > pm8001_tag_free(pm8001_ha, tag); > -- > 2.33.0.685.g46640cef36-goog >
On Tue, 28 Sep 2021 19:58:47 -0700, Igor Pylypiv wrote: > pm8001_mpi_get_nvmd_resp() handles a GET_NVMD_DATA response, not > a SET_NVMD_DATA response, as the log statement implies. > > Fixes: 1f889b58716a ("scsi: pm80xx: Fix pm8001_mpi_get_nvmd_resp() > race condition") > > > [...] Applied to 5.16/scsi-queue, thanks! [2/2] scsi: pm80xx: Fix misleading log statement in pm8001_mpi_get_nvmd_resp() https://git.kernel.org/mkp/scsi/c/4084a7235d38
diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c index b73d286bea60..69e5f3db336b 100644 --- a/drivers/scsi/pm8001/pm8001_hwi.c +++ b/drivers/scsi/pm8001/pm8001_hwi.c @@ -3169,7 +3169,7 @@ pm8001_mpi_get_nvmd_resp(struct pm8001_hba_info *pm8001_ha, void *piomb) * fw_control_context->usrAddr */ complete(pm8001_ha->nvmd_completion); - pm8001_dbg(pm8001_ha, MSG, "Set nvm data complete!\n"); + pm8001_dbg(pm8001_ha, MSG, "Get nvmd data complete!\n"); ccb->task = NULL; ccb->ccb_tag = 0xFFFFFFFF; pm8001_tag_free(pm8001_ha, tag);
pm8001_mpi_get_nvmd_resp() handles a GET_NVMD_DATA response, not a SET_NVMD_DATA response, as the log statement implies. Fixes: 1f889b58716a ("scsi: pm80xx: Fix pm8001_mpi_get_nvmd_resp() race condition") Reviewed-by: Changyuan Lyu <changyuanl@google.com> Signed-off-by: Igor Pylypiv <ipylypiv@google.com> --- drivers/scsi/pm8001/pm8001_hwi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)