diff mbox series

[RESEND] mpi3mr:Fix duplicate device entries when scan through sysfs

Message ID 20211014055425.30719-1-sreekanth.reddy@broadcom.com (mailing list archive)
State Accepted
Headers show
Series [RESEND] mpi3mr:Fix duplicate device entries when scan through sysfs | expand

Commit Message

Sreekanth Reddy Oct. 14, 2021, 5:54 a.m. UTC
When the user scans the devices through 'scan' sysfs using below
command then the user will observe duplicate device entries
in lsscsi command output.
echo "- - -" > /sys/class/scsi_host/host0/scan

Fix is to set the shost's max_channel to zero.

Fixes: 824a156633df ("scsi: mpi3mr: Base driver code")
Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
---
 drivers/scsi/mpi3mr/mpi3mr_os.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen Oct. 19, 2021, 3:43 a.m. UTC | #1
On Thu, 14 Oct 2021 11:24:25 +0530, Sreekanth Reddy wrote:

> When the user scans the devices through 'scan' sysfs using below
> command then the user will observe duplicate device entries
> in lsscsi command output.
> echo "- - -" > /sys/class/scsi_host/host0/scan
> 
> Fix is to set the shost's max_channel to zero.
> 
> [...]

Applied to 5.15/scsi-fixes, thanks!

[1/1] mpi3mr:Fix duplicate device entries when scan through sysfs
      https://git.kernel.org/mkp/scsi/c/97e6ea6d7806
diff mbox series

Patch

diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
index 2197988333fe..3cae8803383b 100644
--- a/drivers/scsi/mpi3mr/mpi3mr_os.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_os.c
@@ -3736,7 +3736,7 @@  mpi3mr_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	shost->max_lun = -1;
 	shost->unique_id = mrioc->id;
 
-	shost->max_channel = 1;
+	shost->max_channel = 0;
 	shost->max_id = 0xFFFFFFFF;
 
 	if (prot_mask >= 0)