| Message ID | 20211130202934.5023-3-f.fainelli@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | scsi: SYSFS_FLAG_FW_SEL_BOOT formatting fixes | expand |
On 11/30/21 12:29 PM, Florian Fainelli wrote: > qedi formats SYSFS_FLAG_FW_SEL_BOOT as a byte, and the qla4xxx driver > does exactly the same thing, align them for consistency. > > Suggested-by: Martin K. Petersen <martin.petersen@oracle.com> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > drivers/scsi/qla4xxx/ql4_os.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c > index 8987acc24dac..39b2f833eb26 100644 > --- a/drivers/scsi/qla4xxx/ql4_os.c > +++ b/drivers/scsi/qla4xxx/ql4_os.c > @@ -5734,7 +5734,7 @@ static ssize_t qla4xxx_show_boot_eth_info(void *data, int type, char *buf) > > switch (type) { > case ISCSI_BOOT_ETH_FLAGS: > - rc = sprintf(str, "%d\n", SYSFS_FLAG_FW_SEL_BOOT); > + rc = sprintf(str, "%hhd\n", (char)SYSFS_FLAG_FW_SEL_BOOT); > break; > case ISCSI_BOOT_ETH_INDEX: > rc = sprintf(str, "0\n"); > @@ -5843,7 +5843,7 @@ qla4xxx_show_boot_tgt_info(struct ql4_boot_session_info *boot_sess, int type, > (char *)&boot_conn->chap.intr_secret); > break; > case ISCSI_BOOT_TGT_FLAGS: > - rc = sprintf(str, "%d\n", SYSFS_FLAG_FW_SEL_BOOT); > + rc = sprintf(str, "%hdd\n", (char)SYSFS_FLAG_FW_SEL_BOOT); Sorry, I botched up that one, let me resend.
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 8987acc24dac..39b2f833eb26 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -5734,7 +5734,7 @@ static ssize_t qla4xxx_show_boot_eth_info(void *data, int type, char *buf) switch (type) { case ISCSI_BOOT_ETH_FLAGS: - rc = sprintf(str, "%d\n", SYSFS_FLAG_FW_SEL_BOOT); + rc = sprintf(str, "%hhd\n", (char)SYSFS_FLAG_FW_SEL_BOOT); break; case ISCSI_BOOT_ETH_INDEX: rc = sprintf(str, "0\n"); @@ -5843,7 +5843,7 @@ qla4xxx_show_boot_tgt_info(struct ql4_boot_session_info *boot_sess, int type, (char *)&boot_conn->chap.intr_secret); break; case ISCSI_BOOT_TGT_FLAGS: - rc = sprintf(str, "%d\n", SYSFS_FLAG_FW_SEL_BOOT); + rc = sprintf(str, "%hdd\n", (char)SYSFS_FLAG_FW_SEL_BOOT); break; case ISCSI_BOOT_TGT_NIC_ASSOC: rc = sprintf(str, "0\n");
qedi formats SYSFS_FLAG_FW_SEL_BOOT as a byte, and the qla4xxx driver does exactly the same thing, align them for consistency. Suggested-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- drivers/scsi/qla4xxx/ql4_os.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)