| Message ID | 20211222165427.1855582-1-linux@roeck-us.net (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | scsi: bsg: Ignore bsg queue registration failures again | expand |
On Wed, Dec 22, 2021 at 08:54:27AM -0800, Guenter Roeck wrote: > Since commit 5f7cf82c1d73 ("scsi: bsg: Fix errno when > scsi_bsg_register_queue() fails"), errors from registering the bsg queue > are no longer ignored but returned to the caller. At the same time, the > comment in the code still states that errors are ignored. On top of that, > the message preporting the problem is printed as dev_info, not dev_err. > Both suggest that errors from bsg queue registrations should indeed be > ignored. But there is no good reason to ignore it. The proper fix is to fully handle the errors.
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index d4edce930a4a..caa4ad1f893a 100644 --- a/drivers/scsi/scsi_sysfs.c +++ b/drivers/scsi/scsi_sysfs.c @@ -1391,10 +1391,9 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev) * We're treating error on bsg register as non-fatal, so * pretend nothing went wrong. */ - error = PTR_ERR(sdev->bsg_dev); sdev_printk(KERN_INFO, sdev, - "Failed to register bsg queue, errno=%d\n", - error); + "Failed to register bsg queue, errno=%ld\n", + PTR_ERR(sdev->bsg_dev)); sdev->bsg_dev = NULL; } }
Since commit 5f7cf82c1d73 ("scsi: bsg: Fix errno when scsi_bsg_register_queue() fails"), errors from registering the bsg queue are no longer ignored but returned to the caller. At the same time, the comment in the code still states that errors are ignored. On top of that, the message preporting the problem is printed as dev_info, not dev_err. Both suggest that errors from bsg queue registrations should indeed be ignored. Cc: Jens Axboe <axboe@kernel.dk> Cc: Christoph Hellwig <hch@lst.de> Cc: Jackie Liu <liuyun01@kylinos.cn> Fixes: 5f7cf82c1d73 ("scsi: bsg: Fix errno when scsi_bsg_register_queue() fails" Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- Commit 5f7cf82c1d73 has proliferated to stable releases, so this patch should probably be backported as well. Alternatives: - revert commit 5f7cf82c1d73 - Change the comment to match the code, and print the message as error drivers/scsi/scsi_sysfs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)