| Message ID | 20220106194804.23892-1-hy50.seo@samsung.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v1] scsi: ufs: modify Tactive time setting conditions | expand |
>-----Original Message----- >From: SEO HOYOUNG [mailto:hy50.seo@samsung.com] >Sent: Friday, January 7, 2022 1:18 AM >To: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; >kwmad.kim@samsung.com; alim.akhtar@samsung.com; >avri.altman@wdc.com; jejb@linux.ibm.com; martin.petersen@oracle.com; >beanhuo@micron.com; asutoshd@codeaurora.org; cang@codeaurora.org; >bvanassche@acm.org; grant.jung@samsung.com; >junwoo80.lee@samsung.com; bhoon95.kim@samsung.com >Cc: SEO HOYOUNG <hy50.seo@samsung.com> >Subject: [PATCH v1] scsi: ufs: modify Tactive time setting conditions > >The Tactive time determine the waiting time before burst at hibern8 exit and >is determined by H/W at linkup state However, in the case of samsung >devices, guided host's Tactive time +100us for stability. >If the HCI's Tactive time is equal or greater than the device, +100us should be >set. > >Change-Id: Ie9b502c69264d3e5931ee8b515388094441fa065 Please remove this and advisable to run checkpatch before posting. >Signed-off-by: SEO HOYOUNG <hy50.seo@samsung.com> >--- > drivers/scsi/ufs/ufshcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index >1049e41abd5b..460d2b440d2e 100644 >--- a/drivers/scsi/ufs/ufshcd.c >+++ b/drivers/scsi/ufs/ufshcd.c >@@ -7815,7 +7815,7 @@ static int >ufshcd_quirk_tune_host_pa_tactivate(struct ufs_hba *hba) > peer_pa_tactivate_us = peer_pa_tactivate * > gran_to_us_table[peer_granularity - 1]; > >- if (pa_tactivate_us > peer_pa_tactivate_us) { >+ if (pa_tactivate_us >= peer_pa_tactivate_us) { > u32 new_peer_pa_tactivate; > > new_peer_pa_tactivate = pa_tactivate_us / >-- >2.26.0
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 1049e41abd5b..460d2b440d2e 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -7815,7 +7815,7 @@ static int ufshcd_quirk_tune_host_pa_tactivate(struct ufs_hba *hba) peer_pa_tactivate_us = peer_pa_tactivate * gran_to_us_table[peer_granularity - 1]; - if (pa_tactivate_us > peer_pa_tactivate_us) { + if (pa_tactivate_us >= peer_pa_tactivate_us) { u32 new_peer_pa_tactivate; new_peer_pa_tactivate = pa_tactivate_us /
The Tactive time determine the waiting time before burst at hibern8 exit and is determined by H/W at linkup state However, in the case of samsung devices, guided host's Tactive time +100us for stability. If the HCI's Tactive time is equal or greater than the device, +100us should be set. Change-Id: Ie9b502c69264d3e5931ee8b515388094441fa065 Signed-off-by: SEO HOYOUNG <hy50.seo@samsung.com> --- drivers/scsi/ufs/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)