diff mbox series

lpfc: Remove redundant 'flush_workqueue()' calls

Message ID 20220127014330.1185114-1-chi.minghao@zte.com.cn (mailing list archive)
State Accepted
Headers show
Series lpfc: Remove redundant 'flush_workqueue()' calls | expand

Commit Message

CGEL Jan. 27, 2022, 1:43 a.m. UTC 
From: "Minghao Chi (CGEL ZTE)" <chi.minghao@zte.com.cn>

'destroy_workqueue()' already drains the queue before destroying it,
so there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
---
 drivers/scsi/lpfc/lpfc_init.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Martin K. Petersen Feb. 8, 2022, 4:52 a.m. UTC | #1 
On Thu, 27 Jan 2022 01:43:30 +0000, cgel.zte@gmail.com wrote:

> From: "Minghao Chi (CGEL ZTE)" <chi.minghao@zte.com.cn>
> 
> 'destroy_workqueue()' already drains the queue before destroying it,
> so there is no need to flush it explicitly.
> 
> Remove the redundant 'flush_workqueue()' calls.
> 
> [...]

Applied to 5.18/scsi-queue, thanks!

[1/1] lpfc: Remove redundant 'flush_workqueue()' calls
      https://git.kernel.org/mkp/scsi/c/d1d87c33f47d
diff mbox series

Patch

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index a56f01f659f8..f49ff18cb252 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -8546,7 +8546,6 @@  static void
 lpfc_unset_driver_resource_phase2(struct lpfc_hba *phba)
 {
 	if (phba->wq) {
-		flush_workqueue(phba->wq);
 		destroy_workqueue(phba->wq);
 		phba->wq = NULL;
 	}