diff mbox series

scsi: hisi_sas: remove stray fallthrough annotation

Message ID 20220317075214.GC25237@kili (mailing list archive)
State Accepted
Headers show
Series scsi: hisi_sas: remove stray fallthrough annotation | expand

Commit Message

Dan Carpenter March 17, 2022, 7:52 a.m. UTC
This case statement doesn't fall through any more so remove the
fallthrough annotation.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/scsi/hisi_sas/hisi_sas_main.c | 1 -
 1 file changed, 1 deletion(-)

Comments

John Garry March 17, 2022, 8:47 a.m. UTC | #1
On 17/03/2022 07:52, Dan Carpenter wrote:
> This case statement doesn't fall through any more so remove the
> fallthrough annotation.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks

Acked-by: John Garry <john.garry@huawei.com>

> ---
>   drivers/scsi/hisi_sas/hisi_sas_main.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
> index 461ef8a76c4c..4bda2f6cb352 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
> @@ -442,7 +442,6 @@ void hisi_sas_task_deliver(struct hisi_hba *hisi_hba,
>   	case SAS_PROTOCOL_INTERNAL_ABORT:
>   		hisi_sas_task_prep_abort(hisi_hba, slot);
>   		break;
> -	fallthrough;
>   	default:
>   		return;
>   	}
Martin K. Petersen March 30, 2022, 3:53 a.m. UTC | #2
Dan,

> This case statement doesn't fall through any more so remove the
> fallthrough annotation.

Applied to 5.18/scsi-staging, thanks!
Martin K. Petersen April 7, 2022, 1:35 p.m. UTC | #3
On Thu, 17 Mar 2022 10:52:14 +0300, Dan Carpenter wrote:

> This case statement doesn't fall through any more so remove the
> fallthrough annotation.
> 
> 

Applied to 5.18/scsi-fixes, thanks!

[1/1] scsi: hisi_sas: remove stray fallthrough annotation
      https://git.kernel.org/mkp/scsi/c/066f4c31945c
diff mbox series

Patch

diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 461ef8a76c4c..4bda2f6cb352 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -442,7 +442,6 @@  void hisi_sas_task_deliver(struct hisi_hba *hisi_hba,
 	case SAS_PROTOCOL_INTERNAL_ABORT:
 		hisi_sas_task_prep_abort(hisi_hba, slot);
 		break;
-	fallthrough;
 	default:
 		return;
 	}