diff mbox series

[03/13] scsi: qedi: Use QEDI_MODE_NORMAL for error handling

Message ID 20220517222448.25612-4-michael.christie@oracle.com (mailing list archive)
State Superseded
Headers show
Series iscsi fixes, perf improvements and cleanups | expand

Commit Message

Mike Christie May 17, 2022, 10:24 p.m. UTC 
When handling errors that lead to host removal use QEDI_MODE_NORMAL. There
is currently no difference in behavior between NORMAL and SHUTDOWN, but in
the next patch we will want to know when we are called from the pci_driver
shutdown callout vs remove/err_handler so we know when userspace is up.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
 drivers/scsi/qedi/qedi_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lee Duncan May 18, 2022, 4:04 p.m. UTC | #1 
On 5/17/22 15:24, Mike Christie wrote:
> When handling errors that lead to host removal use QEDI_MODE_NORMAL. There
> is currently no difference in behavior between NORMAL and SHUTDOWN, but in
> the next patch we will want to know when we are called from the pci_driver
> shutdown callout vs remove/err_handler so we know when userspace is up.
> 
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> ---
>   drivers/scsi/qedi/qedi_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
> index 83ffba7f51da..deebe62e2b41 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -2491,7 +2491,7 @@ static void qedi_board_disable_work(struct work_struct *work)
>   	if (test_and_set_bit(QEDI_IN_SHUTDOWN, &qedi->flags))
>   		return;
>   
> -	__qedi_remove(qedi->pdev, QEDI_MODE_SHUTDOWN);
> +	__qedi_remove(qedi->pdev, QEDI_MODE_NORMAL);
>   }
>   
>   static void qedi_shutdown(struct pci_dev *pdev)

Reviewed-by: Lee Duncan <lduncan@suse.com>
diff mbox series

Patch

diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 83ffba7f51da..deebe62e2b41 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -2491,7 +2491,7 @@  static void qedi_board_disable_work(struct work_struct *work)
 	if (test_and_set_bit(QEDI_IN_SHUTDOWN, &qedi->flags))
 		return;
 
-	__qedi_remove(qedi->pdev, QEDI_MODE_SHUTDOWN);
+	__qedi_remove(qedi->pdev, QEDI_MODE_NORMAL);
 }
 
 static void qedi_shutdown(struct pci_dev *pdev)