| Message ID | 20220801124144.11458-4-sreekanth.reddy@broadcom.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | mpt3sas: Few enhancements and fixes | expand |
On Mon, Aug 01, 2022 at 06:11:43PM +0530, Sreekanth Reddy wrote:
> Increase cmd_per_lun to 128
Why?
On Mon, Aug 1, 2022 at 11:28 PM Christoph Hellwig <hch@infradead.org> wrote: > > On Mon, Aug 01, 2022 at 06:11:43PM +0530, Sreekanth Reddy wrote: > > Increase cmd_per_lun to 128 > > Why? In one of the earlier thread (mpt3sas fails to allocate budget_map and detects no devices - https://lore.kernel.org/all/YdcZwVUFGUPgkbLn@T590/T/) it has been mentioned that cmd_per_lun with value 7 is so small and hence we thought it is better to increase it to 128. Thanks, Sreekanth
On Tue, Aug 02, 2022 at 02:13:42PM +0530, Sreekanth Reddy wrote: > On Mon, Aug 1, 2022 at 11:28 PM Christoph Hellwig <hch@infradead.org> wrote: > > > > On Mon, Aug 01, 2022 at 06:11:43PM +0530, Sreekanth Reddy wrote: > > > Increase cmd_per_lun to 128 > > > > Why? > > In one of the earlier thread (mpt3sas fails to allocate budget_map and > detects no devices - > https://lore.kernel.org/all/YdcZwVUFGUPgkbLn@T590/T/) it has been > mentioned that cmd_per_lun with value 7 is so small and hence we > thought it is better to increase it to 128. Well, that is what the commit log is for. I can see all by myself that you are increasing it, so you need to explain why.
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index f321733..e54747a 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -11974,7 +11974,7 @@ static struct scsi_host_template mpt3sas_driver_template = { .sg_tablesize = MPT3SAS_SG_DEPTH, .max_sectors = 32767, .max_segment_size = 0xffffffff, - .cmd_per_lun = 7, + .cmd_per_lun = 128, .shost_groups = mpt3sas_host_groups, .sdev_groups = mpt3sas_dev_groups, .track_queue_depth = 1,
Increase cmd_per_lun to 128 Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)