| Message ID | 20220809182518.3046935-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | scsi: aic79xx: make read-only array tok_list static const | expand |
On 8/9/22 11:25, Colin Ian King wrote: > Don't populate the read-only array tok_list on the stack but instead make > it static const. Also makes the object code a little smaller. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/scsi/aic7xxx/aic79xx_osm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c > index 928099163f0f..4ed40e6c5522 100644 > --- a/drivers/scsi/aic7xxx/aic79xx_osm.c > +++ b/drivers/scsi/aic7xxx/aic79xx_osm.c > @@ -1044,7 +1044,7 @@ ahd_parse_brace_option(char *opt_name, char *opt_arg, char *end, int depth, > int instance; > int targ; > int done; > - char tok_list[] = {'.', ',', '{', '}', '\0'}; > + static const char tok_list[] = {'.', ',', '{', '}', '\0'}; Has it been considered to write the above code as follows? static const char tok_list[] = ".,{}"; Thanks, Bart.
diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c index 928099163f0f..4ed40e6c5522 100644 --- a/drivers/scsi/aic7xxx/aic79xx_osm.c +++ b/drivers/scsi/aic7xxx/aic79xx_osm.c @@ -1044,7 +1044,7 @@ ahd_parse_brace_option(char *opt_name, char *opt_arg, char *end, int depth, int instance; int targ; int done; - char tok_list[] = {'.', ',', '{', '}', '\0'}; + static const char tok_list[] = {'.', ',', '{', '}', '\0'}; /* All options use a ':' name/arg separator */ if (*opt_arg != ':')
Don't populate the read-only array tok_list on the stack but instead make it static const. Also makes the object code a little smaller. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/scsi/aic7xxx/aic79xx_osm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)