| Message ID | 20220912114803.7644-1-njavali@marvell.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | qedf: Populate sysfs attributes for vport | expand |
This patch addresses a day one bug found by a Red Hat QA Test. This patch has been applied to RHEL test build and proven to resolve the bug. Tested-by: Guangwu Zhang <guazhang@redhat.com> Reviewed-by: John Meneghini <jmeneghi@redhat.com> On 9/12/22 07:48, Nilesh Javali wrote: > From: Saurav Kashyap <skashyap@marvell.com> > > Copy speed, supported_speed, frame_size and update port_type for NPIV port. > > Signed-off-by: Saurav Kashyap <skashyap@marvell.com> > Signed-off-by: Nilesh Javali <njavali@marvell.com> > --- > drivers/scsi/qedf/qedf_main.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c > index 3d6b137314f3..cc6d9decf62c 100644 > --- a/drivers/scsi/qedf/qedf_main.c > +++ b/drivers/scsi/qedf/qedf_main.c > @@ -1921,6 +1921,27 @@ static int qedf_vport_create(struct fc_vport *vport, bool disabled) > fc_vport_setlink(vn_port); > } > > + /* Set symbolic node name */ > + if (base_qedf->pdev->device == QL45xxx) > + snprintf(fc_host_symbolic_name(vn_port->host), 256, > + "Marvell FastLinQ 45xxx FCoE v%s", QEDF_VERSION); > + > + if (base_qedf->pdev->device == QL41xxx) > + snprintf(fc_host_symbolic_name(vn_port->host), 256, > + "Marvell FastLinQ 41xxx FCoE v%s", QEDF_VERSION); > + > + /* Set supported speed */ > + fc_host_supported_speeds(vn_port->host) = n_port->link_supported_speeds; > + > + /* Set speed */ > + vn_port->link_speed = n_port->link_speed; > + > + /* Set port type */ > + fc_host_port_type(vn_port->host) = FC_PORTTYPE_NPIV; > + > + /* Set maxframe size */ > + fc_host_maxframe_size(vn_port->host) = n_port->mfs; > + > QEDF_INFO(&(base_qedf->dbg_ctx), QEDF_LOG_NPIV, "vn_port=%p.\n", > vn_port); >
Nilesh, > Copy speed, supported_speed, frame_size and update port_type for NPIV > port. The commit description should explain why this change is needed. Thanks!
diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 3d6b137314f3..cc6d9decf62c 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -1921,6 +1921,27 @@ static int qedf_vport_create(struct fc_vport *vport, bool disabled) fc_vport_setlink(vn_port); } + /* Set symbolic node name */ + if (base_qedf->pdev->device == QL45xxx) + snprintf(fc_host_symbolic_name(vn_port->host), 256, + "Marvell FastLinQ 45xxx FCoE v%s", QEDF_VERSION); + + if (base_qedf->pdev->device == QL41xxx) + snprintf(fc_host_symbolic_name(vn_port->host), 256, + "Marvell FastLinQ 41xxx FCoE v%s", QEDF_VERSION); + + /* Set supported speed */ + fc_host_supported_speeds(vn_port->host) = n_port->link_supported_speeds; + + /* Set speed */ + vn_port->link_speed = n_port->link_speed; + + /* Set port type */ + fc_host_port_type(vn_port->host) = FC_PORTTYPE_NPIV; + + /* Set maxframe size */ + fc_host_maxframe_size(vn_port->host) = n_port->mfs; + QEDF_INFO(&(base_qedf->dbg_ctx), QEDF_LOG_NPIV, "vn_port=%p.\n", vn_port);