diff mbox series

scsi: fnic: drop unnecessary NULL check in is_fnic_fip_flogi_reject()

Message ID 20221216103039.202774-1-aleksei.kodanev@bell-sw.com (mailing list archive)
State New, archived
Headers show
Series scsi: fnic: drop unnecessary NULL check in is_fnic_fip_flogi_reject() | expand

Commit Message

Alexey Kodanev Dec. 16, 2022, 10:30 a.m. UTC
if (desc->fip_dtype == FIP_DT_FLOGI) {
        ...
        els = (struct fip_encaps *)desc;
        fh = (struct fc_frame_header *)(els + 1);

'fh' can't be NULL here after shifting a valid pointer 'desc'.

Detected using the static analysis tool - Svace.
Signed-off-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
---
 drivers/scsi/fnic/fnic_fcs.c | 3 ---
 1 file changed, 3 deletions(-)
diff mbox series

Patch

diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c
index 79ddfaaf71a4..acf593467012 100644
--- a/drivers/scsi/fnic/fnic_fcs.c
+++ b/drivers/scsi/fnic/fnic_fcs.c
@@ -337,9 +337,6 @@  static inline int is_fnic_fip_flogi_reject(struct fcoe_ctlr *fip,
 		els = (struct fip_encaps *)desc;
 		fh = (struct fc_frame_header *)(els + 1);
 
-		if (!fh)
-			return 0;
-
 		/*
 		 * ELS command code, reason and explanation should be = Reject,
 		 * unsupported command and insufficient resource