| Message ID | 20230118225447.2809787-10-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for segments smaller than one page | expand |
Hi Bart, On Wed, Jan 18, 2023 at 02:54:47PM -0800, Bart Van Assche wrote: > Since the maximum segment size supported by the Exynos controller is 4 > KiB, this controller needs CONFIG_BLK_SUB_PAGE_SEGMENTS if the page size > exceeds 4 KiB. > > Cc: Alim Akhtar <alim.akhtar@samsung.com> > Cc: Kiwoong Kim <kwmad.kim@samsung.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > drivers/ufs/host/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/ufs/host/Kconfig b/drivers/ufs/host/Kconfig > index 4cc2dbd79ed0..376a4039912d 100644 > --- a/drivers/ufs/host/Kconfig > +++ b/drivers/ufs/host/Kconfig > @@ -117,6 +117,7 @@ config SCSI_UFS_TI_J721E > config SCSI_UFS_EXYNOS > tristate "Exynos specific hooks to UFS controller platform driver" > depends on SCSI_UFSHCD_PLATFORM && (ARCH_EXYNOS || COMPILE_TEST) > + select BLK_SUB_PAGE_SEGMENTS if PAGE_SIZE > 4096 I remember that PAGE_SIZE is still 4K on Android kernel, so UFS_EXYNOS should work just fine, or Android kernel is going to change PAGE_SIZE? Thanks, Ming
On 1/27/23 19:55, Ming Lei wrote: > I remember that PAGE_SIZE is still 4K on Android kernel, so > UFS_EXYNOS should work just fine, or Android kernel is going > to change PAGE_SIZE? Hi Ming, We want to improve Android performance by increasing the page size from 4 KiB to 16 KiB. Hence this patch series. Thanks, Bart.
diff --git a/drivers/ufs/host/Kconfig b/drivers/ufs/host/Kconfig index 4cc2dbd79ed0..376a4039912d 100644 --- a/drivers/ufs/host/Kconfig +++ b/drivers/ufs/host/Kconfig @@ -117,6 +117,7 @@ config SCSI_UFS_TI_J721E config SCSI_UFS_EXYNOS tristate "Exynos specific hooks to UFS controller platform driver" depends on SCSI_UFSHCD_PLATFORM && (ARCH_EXYNOS || COMPILE_TEST) + select BLK_SUB_PAGE_SEGMENTS if PAGE_SIZE > 4096 help This selects the Samsung Exynos SoC specific additions to UFSHCD platform driver. UFS host on Samsung Exynos SoC includes HCI and
Since the maximum segment size supported by the Exynos controller is 4 KiB, this controller needs CONFIG_BLK_SUB_PAGE_SEGMENTS if the page size exceeds 4 KiB. Cc: Alim Akhtar <alim.akhtar@samsung.com> Cc: Kiwoong Kim <kwmad.kim@samsung.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/ufs/host/Kconfig | 1 + 1 file changed, 1 insertion(+)