| Message ID | 20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-4-3ead1e418fe4@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | arm64: qcom: sm8450: bindings check cleanup | expand |
On 23/03/2023 11:25, Neil Armstrong wrote: > Fixes the following DT bindings check error: > domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: > 'pinctrl-[0-9]+' > domain-idle-states: cluster-sleep-1: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: > 'pinctrl-[0-9]+' I don't get from the commit msg why these properties are not correct here. The idle states allow them, so maybe something is missing in the binding? At least commit msg should explain this. Best regards, Krzysztof
On 23/03/2023 11:51, Krzysztof Kozlowski wrote: > On 23/03/2023 11:25, Neil Armstrong wrote: >> Fixes the following DT bindings check error: >> domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: >> 'pinctrl-[0-9]+' >> domain-idle-states: cluster-sleep-1: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: >> 'pinctrl-[0-9]+' > > I don't get from the commit msg why these properties are not correct > here. The idle states allow them, so maybe something is missing in the > binding? At least commit msg should explain this. The domain-idle-states bindings doesn't document those 2 properties, so perhaps it's missing ? Neil > > Best regards, > Krzysztof >
On 23/03/2023 14:14, Neil Armstrong wrote: > On 23/03/2023 11:51, Krzysztof Kozlowski wrote: >> On 23/03/2023 11:25, Neil Armstrong wrote: >>> Fixes the following DT bindings check error: >>> domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: >>> 'pinctrl-[0-9]+' >>> domain-idle-states: cluster-sleep-1: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: >>> 'pinctrl-[0-9]+' >> >> I don't get from the commit msg why these properties are not correct >> here. The idle states allow them, so maybe something is missing in the >> binding? At least commit msg should explain this. > > The domain-idle-states bindings doesn't document those 2 properties, so perhaps it's missing ? Ah, you are right. These were copied from CPU idle states, so here they do not make sense. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index 78fb65bd15cc..ff55fcfdd676 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -255,22 +255,18 @@ BIG_CPU_SLEEP_0: cpu-sleep-1-0 { domain-idle-states { CLUSTER_SLEEP_0: cluster-sleep-0 { compatible = "domain-idle-state"; - idle-state-name = "cluster-l3-off"; arm,psci-suspend-param = <0x41000044>; entry-latency-us = <1050>; exit-latency-us = <2500>; min-residency-us = <5309>; - local-timer-stop; }; CLUSTER_SLEEP_1: cluster-sleep-1 { compatible = "domain-idle-state"; - idle-state-name = "cluster-power-collapse"; arm,psci-suspend-param = <0x4100c344>; entry-latency-us = <2700>; exit-latency-us = <3500>; min-residency-us = <13959>; - local-timer-stop; }; }; };
Fixes the following DT bindings check error: domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: 'pinctrl-[0-9]+' domain-idle-states: cluster-sleep-1: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ---- 1 file changed, 4 deletions(-)