From patchwork Sun Mar 26 00:32:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 13187932 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 396EDC6FD1C for ; Sun, 26 Mar 2023 00:33:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbjCZAdT (ORCPT ); Sat, 25 Mar 2023 20:33:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjCZAdS (ORCPT ); Sat, 25 Mar 2023 20:33:18 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12DBABDF8 for ; Sat, 25 Mar 2023 17:32:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679790748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Vvl/Cszr83QpVo2zLAzWMSGgk3m+9bIrTI3yG08ent8=; b=Yof+X1952AFQ5Mr1Vb8u1Bo36boUn4JNixyITWM8TmPaZLCHa3ZU2bYbo1wovj+6/XA/3O TAutJ+8WBxZQr1iLuinLh036har6c27/533BCwoZeMpxb7lnv3zFhsiT+UnsRYi6rbl8DQ DxwDnbyGvevi0d2JHjlnKD0XObMHuY8= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-l_HBFXRfOle4XJqz5yf9ww-1; Sat, 25 Mar 2023 20:32:26 -0400 X-MC-Unique: l_HBFXRfOle4XJqz5yf9ww-1 Received: by mail-qv1-f71.google.com with SMTP id e1-20020a0cd641000000b005b47df84f6eso2563846qvj.0 for ; Sat, 25 Mar 2023 17:32:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679790746; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Vvl/Cszr83QpVo2zLAzWMSGgk3m+9bIrTI3yG08ent8=; b=KeRc+mqH8suEqYdHXAgkXyArPTPkxRE+yqTqs/SYS8PSMZP+6zGiDgj1jQsoScqgA8 qr+8J5O58prd3w11AyfOzKV18ZoZ9Uhhj4SStAqoNLia6fAvo9p73zW6aw8OKnEJBD+E LgoBx+D0YMtVRXDtdYFy19QDgnDuxF/D0ooZchztFax2HTGIVZGeTxa5tEgA0hbHUAp7 O45ZDa787WDGwyuKzVaLRgOPX4gGGsryMwUV3GcImPS48vAPhkMR+e0qN47RAgkNjCpH TamY00Ppa+ShZfOzexSRwcLy7l/gNguO548VymcO7tcoJ083ijup2VTq3afLKmb858/B GuMA== X-Gm-Message-State: AO0yUKU1HxSu7wXpTgvSWjuUiGZUyC2da3Wl2quJFpWhNFQMSAL/WLhP mdh8X/3SVmD50pOWCTBk4E1kBjr8C4v6ZZV9Z9X9UkWtICfFix1d1ee9Ws5ABTWE1YCkfvemwJc E6GHYECGGQjvAadiUP7y4iQ== X-Received: by 2002:a05:6214:2aa5:b0:5dd:b12c:7536 with SMTP id js5-20020a0562142aa500b005ddb12c7536mr11178014qvb.15.1679790746264; Sat, 25 Mar 2023 17:32:26 -0700 (PDT) X-Google-Smtp-Source: AKy350b+Pa/uA21H+Zv/sD23H6AYDuKi2PaRBJzNHIHJxF75572oevVIi5sKRN9bea14HCN3kO7fDw== X-Received: by 2002:a05:6214:2aa5:b0:5dd:b12c:7536 with SMTP id js5-20020a0562142aa500b005ddb12c7536mr11178000qvb.15.1679790745992; Sat, 25 Mar 2023 17:32:25 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id g1-20020a37b601000000b00743592b4745sm15389120qkf.109.2023.03.25.17.32.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Mar 2023 17:32:25 -0700 (PDT) From: Tom Rix To: jejb@linux.ibm.com, martin.petersen@oracle.com, nathan@kernel.org, ndesaulniers@google.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix Subject: [PATCH] scsi: scsi_transport_fc: remove unused desc_cnt variable Date: Sat, 25 Mar 2023 20:32:22 -0400 Message-Id: <20230326003222.1343671-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org clang with W=1 reports drivers/scsi/scsi_transport_fc.c:908:6: error: variable 'desc_cnt' set but not used [-Werror,-Wunused-but-set-variable] u32 desc_cnt = 0, bytes_remain; ^ This variable is not used so remove it. Signed-off-by: Tom Rix Reviewed-by: Himanshu Madhani Reviewed-by: Benjamin Block --- drivers/scsi/scsi_transport_fc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c index f12e9467ebb4..64ff2629eaf9 100644 --- a/drivers/scsi/scsi_transport_fc.c +++ b/drivers/scsi/scsi_transport_fc.c @@ -905,7 +905,7 @@ fc_host_fpin_rcv(struct Scsi_Host *shost, u32 fpin_len, char *fpin_buf, { struct fc_els_fpin *fpin = (struct fc_els_fpin *)fpin_buf; struct fc_tlv_desc *tlv; - u32 desc_cnt = 0, bytes_remain; + u32 bytes_remain; u32 dtag; enum fc_host_event_code event_code = event_acknowledge ? FCH_EVT_LINK_FPIN_ACK : FCH_EVT_LINK_FPIN; @@ -932,7 +932,6 @@ fc_host_fpin_rcv(struct Scsi_Host *shost, u32 fpin_len, char *fpin_buf, fc_fpin_congn_stats_update(shost, tlv); } - desc_cnt++; bytes_remain -= FC_TLV_DESC_SZ_FROM_LENGTH(tlv); tlv = fc_tlv_next_desc(tlv); }