diff mbox series

[v4,4/5] scsi: ufs: Declare ufshcd_{hold,release}() once

Message ID 20230529202640.11883-5-bvanassche@acm.org (mailing list archive)
State Accepted
Commit 4b68b7f9c46d90c541d39c8b397a86ac0ca4c765
Headers show
Series ufs: Do not requeue while ungating the clock | expand

Commit Message

Bart Van Assche May 29, 2023, 8:26 p.m. UTC
ufshcd_hold() and ufshcd_release are declared twice: once in
drivers/ufs/core/ufshcd-priv.h and a second time in include/ufs/ufshcd.h.
Remove the declarations from ufshcd-priv.h.

Fixes: dd11376b9f1b ("scsi: ufs: Split the drivers/scsi/ufs directory")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 drivers/ufs/core/ufshcd-priv.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Adrian Hunter May 30, 2023, 9:48 a.m. UTC | #1
On 29/05/23 23:26, Bart Van Assche wrote:
> ufshcd_hold() and ufshcd_release are declared twice: once in
> drivers/ufs/core/ufshcd-priv.h and a second time in include/ufs/ufshcd.h.
> Remove the declarations from ufshcd-priv.h.
> 
> Fixes: dd11376b9f1b ("scsi: ufs: Split the drivers/scsi/ufs directory")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/ufs/core/ufshcd-priv.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/ufs/core/ufshcd-priv.h b/drivers/ufs/core/ufshcd-priv.h
> index d53b93c21a0c..8f58c2169398 100644
> --- a/drivers/ufs/core/ufshcd-priv.h
> +++ b/drivers/ufs/core/ufshcd-priv.h
> @@ -84,9 +84,6 @@ unsigned long ufshcd_mcq_poll_cqe_lock(struct ufs_hba *hba,
>  int ufshcd_read_string_desc(struct ufs_hba *hba, u8 desc_index,
>  			    u8 **buf, bool ascii);
>  
> -int ufshcd_hold(struct ufs_hba *hba, bool async);
> -void ufshcd_release(struct ufs_hba *hba);
> -
>  int ufshcd_send_uic_cmd(struct ufs_hba *hba, struct uic_command *uic_cmd);
>  
>  int ufshcd_exec_raw_upiu_cmd(struct ufs_hba *hba,
Keoseong Park May 31, 2023, 7:59 a.m. UTC | #2
>ufshcd_hold() and ufshcd_release are declared twice: once in
>drivers/ufs/core/ufshcd-priv.h and a second time in include/ufs/ufshcd.h.
>Remove the declarations from ufshcd-priv.h.
>
>Fixes: dd11376b9f1b ("scsi: ufs: Split the drivers/scsi/ufs directory")
>Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Reviewed-by: Keoseong Park <keosung.park@samsung.com>

Best Regards,
Keoseong

>---
> drivers/ufs/core/ufshcd-priv.h | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/drivers/ufs/core/ufshcd-priv.h b/drivers/ufs/core/ufshcd-priv.h
>index d53b93c21a0c..8f58c2169398 100644
>--- a/drivers/ufs/core/ufshcd-priv.h
>+++ b/drivers/ufs/core/ufshcd-priv.h
>@@ -84,9 +84,6 @@ unsigned long ufshcd_mcq_poll_cqe_lock(struct ufs_hba *hba,
> int ufshcd_read_string_desc(struct ufs_hba *hba, u8 desc_index,
> 			    u8 **buf, bool ascii);
> 
>-int ufshcd_hold(struct ufs_hba *hba, bool async);
>-void ufshcd_release(struct ufs_hba *hba);
>-
> int ufshcd_send_uic_cmd(struct ufs_hba *hba, struct uic_command *uic_cmd);
> 
> int ufshcd_exec_raw_upiu_cmd(struct ufs_hba *hba,
diff mbox series

Patch

diff --git a/drivers/ufs/core/ufshcd-priv.h b/drivers/ufs/core/ufshcd-priv.h
index d53b93c21a0c..8f58c2169398 100644
--- a/drivers/ufs/core/ufshcd-priv.h
+++ b/drivers/ufs/core/ufshcd-priv.h
@@ -84,9 +84,6 @@  unsigned long ufshcd_mcq_poll_cqe_lock(struct ufs_hba *hba,
 int ufshcd_read_string_desc(struct ufs_hba *hba, u8 desc_index,
 			    u8 **buf, bool ascii);
 
-int ufshcd_hold(struct ufs_hba *hba, bool async);
-void ufshcd_release(struct ufs_hba *hba);
-
 int ufshcd_send_uic_cmd(struct ufs_hba *hba, struct uic_command *uic_cmd);
 
 int ufshcd_exec_raw_upiu_cmd(struct ufs_hba *hba,