| Message ID | 20230912074715.424062-3-dlemoal@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Minor cleanups | expand |
On 12/09/2023 08:47, Damien Le Moal wrote: > sas_set_phy_speed() is used only within sas_init.c. Declare this > function as static. > > Signed-off-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: John Garry <john.g.garry@oracle.com> > --- > drivers/scsi/libsas/sas_init.c | 4 ++-- > include/scsi/libsas.h | 1 - > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/libsas/sas_init.c b/drivers/scsi/libsas/sas_init.c > index 8586dc79f2a0..9c8cc723170d 100644 > --- a/drivers/scsi/libsas/sas_init.c > +++ b/drivers/scsi/libsas/sas_init.c > @@ -315,8 +315,8 @@ int sas_phy_reset(struct sas_phy *phy, int hard_reset) > } > EXPORT_SYMBOL_GPL(sas_phy_reset); > > -int sas_set_phy_speed(struct sas_phy *phy, > - struct sas_phy_linkrates *rates) > +static int sas_set_phy_speed(struct sas_phy *phy, > + struct sas_phy_linkrates *rates) > { > int ret; > > diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h > index 87f194925b3c..5ee86b225359 100644 > --- a/include/scsi/libsas.h > +++ b/include/scsi/libsas.h > @@ -679,7 +679,6 @@ extern void sas_resume_ha(struct sas_ha_struct *sas_ha); > extern void sas_resume_ha_no_sync(struct sas_ha_struct *sas_ha); > extern void sas_suspend_ha(struct sas_ha_struct *sas_ha); > > -int sas_set_phy_speed(struct sas_phy *phy, struct sas_phy_linkrates *rates); > int sas_phy_reset(struct sas_phy *phy, int hard_reset); > int sas_phy_enable(struct sas_phy *phy, int enable); > extern int sas_queuecommand(struct Scsi_Host *, struct scsi_cmnd *);
diff --git a/drivers/scsi/libsas/sas_init.c b/drivers/scsi/libsas/sas_init.c index 8586dc79f2a0..9c8cc723170d 100644 --- a/drivers/scsi/libsas/sas_init.c +++ b/drivers/scsi/libsas/sas_init.c @@ -315,8 +315,8 @@ int sas_phy_reset(struct sas_phy *phy, int hard_reset) } EXPORT_SYMBOL_GPL(sas_phy_reset); -int sas_set_phy_speed(struct sas_phy *phy, - struct sas_phy_linkrates *rates) +static int sas_set_phy_speed(struct sas_phy *phy, + struct sas_phy_linkrates *rates) { int ret; diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h index 87f194925b3c..5ee86b225359 100644 --- a/include/scsi/libsas.h +++ b/include/scsi/libsas.h @@ -679,7 +679,6 @@ extern void sas_resume_ha(struct sas_ha_struct *sas_ha); extern void sas_resume_ha_no_sync(struct sas_ha_struct *sas_ha); extern void sas_suspend_ha(struct sas_ha_struct *sas_ha); -int sas_set_phy_speed(struct sas_phy *phy, struct sas_phy_linkrates *rates); int sas_phy_reset(struct sas_phy *phy, int hard_reset); int sas_phy_enable(struct sas_phy *phy, int enable); extern int sas_queuecommand(struct Scsi_Host *, struct scsi_cmnd *);
sas_set_phy_speed() is used only within sas_init.c. Declare this function as static. Signed-off-by: Damien Le Moal <dlemoal@kernel.org> --- drivers/scsi/libsas/sas_init.c | 4 ++-- include/scsi/libsas.h | 1 - 2 files changed, 2 insertions(+), 3 deletions(-)