From patchwork Sat Sep 23 00:29:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 13396458 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE63CCE7A88 for ; Sat, 23 Sep 2023 00:31:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231162AbjIWAbG (ORCPT ); Fri, 22 Sep 2023 20:31:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230521AbjIWAaM (ORCPT ); Fri, 22 Sep 2023 20:30:12 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA029B9; Fri, 22 Sep 2023 17:30:02 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 041B9C433CB; Sat, 23 Sep 2023 00:30:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695429002; bh=qrUl5SH+B8SP/ZoBFwIfkCLObB6aWz8x19i2XQMuplw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mN3cIRbiQ6MXYU3dISFozdtpm6qQ3DG4GzEf8Y8wFMQVo4lrZkxmq6p0oubg29+ud xzHpL0+NcBmUM2zRiT/I9sZdTBZDFBO7js919AITXYsEmtq4LbB+Pi9vZ4NtMb9LJf b289EyYn48+Q+HAU3NC3c9L36bNNOuSXPcfr96zxaHtAZmCOLdIdrsJRRwc6w+vTbO RFQCptUhzv8gHZwogXiWLOoV2xILqQpjD/Kn7L/veRkiwf4dCukVXu5kvItJs864tQ s2xI2ilX7yOW1KeEzidsoI4jt7jrDsqtV7w4kbSeiTOaJh8O0Z+IPLusRvrQKSjtmV Urc9NDYd7181g== From: Damien Le Moal To: linux-ide@vger.kernel.org Cc: linux-scsi@vger.kernel.org, "Martin K . Petersen" , John Garry , Rodrigo Vivi , Paul Ausbeck , Kai-Heng Feng , Joe Breuer , Geert Uytterhoeven , Chia-Lin Kao Subject: [PATCH v6 18/23] ata: libata-core: Do not poweroff runtime suspended ports Date: Sat, 23 Sep 2023 09:29:27 +0900 Message-ID: <20230923002932.1082348-19-dlemoal@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230923002932.1082348-1-dlemoal@kernel.org> References: <20230923002932.1082348-1-dlemoal@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org When powering off, there is no need to suspend a port that has already been runtime suspended. Skip the EH PM request in ata_port_pm_poweroff() in this case. Signed-off-by: Damien Le Moal Reviewed-by: Hannes Reinecke Tested-by: Chia-Lin Kao (AceLan) Tested-by: Geert Uytterhoeven Reviewed-by: Martin K. Petersen --- drivers/ata/libata-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 6773a1e52dad..df6ed386e6fc 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -5215,7 +5215,8 @@ static int ata_port_pm_freeze(struct device *dev) static int ata_port_pm_poweroff(struct device *dev) { - ata_port_suspend(to_ata_port(dev), PMSG_HIBERNATE, false); + if (!pm_runtime_suspended(dev)) + ata_port_suspend(to_ata_port(dev), PMSG_HIBERNATE, false); return 0; }