From patchwork Wed Sep 27 14:18:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 13400949 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77D40E80AB7 for ; Wed, 27 Sep 2023 14:19:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232236AbjI0OTs (ORCPT ); Wed, 27 Sep 2023 10:19:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232154AbjI0OTG (ORCPT ); Wed, 27 Sep 2023 10:19:06 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C6E7139; Wed, 27 Sep 2023 07:19:05 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3A7BC433CA; Wed, 27 Sep 2023 14:19:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695824345; bh=B/LOcvpJHNZI8Taj8thEnE9tb7Zy6HMTbO08wRi1qFA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=k/X/ytEM8TUUL5jocOL6Sdg4in+cWCxzJ5dH6ogO/3p9FAgfFmXLSTBLl+Ur7wrX7 1GB+++azqgU6RrbqknUhT3lQihHBuX2hbz5dzdmeSDgF4OGWL4ij9e8uXiNcZ400ml gXQD/KHMXWBrbp/0ZmdutgdwoJRLrL2xjgv9jGa1NHMlxwbdoJ/BJjtqFEo29KdG/0 /RrjdfXs6flhLPQAl+hY+h0jIWhBNZ8P0gXSfdpGtlbYK2kghjnCzjkgNpvzUQ3EI3 4lSxMjLDesvd09WJDHSmxvPUFPVUZnYtVHSMnolOpT93a8X0J66wkM0PcjgvwEUpSk Sfk0QAK5uGBYQ== From: Damien Le Moal To: linux-ide@vger.kernel.org Cc: linux-scsi@vger.kernel.org, "Martin K . Petersen" , John Garry , Rodrigo Vivi , Paul Ausbeck , Kai-Heng Feng , Joe Breuer , Geert Uytterhoeven , Chia-Lin Kao Subject: [PATCH v8 20/23] ata: libata-sata: Improve ata_sas_slave_configure() Date: Wed, 27 Sep 2023 23:18:25 +0900 Message-ID: <20230927141828.90288-21-dlemoal@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230927141828.90288-1-dlemoal@kernel.org> References: <20230927141828.90288-1-dlemoal@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Change ata_sas_slave_configure() to return the return value of ata_scsi_dev_config() to ensure that any error from that function is propagated to libsas. Signed-off-by: Damien Le Moal Reviewed-by: Hannes Reinecke Reviewed-by: John Garry Tested-by: Chia-Lin Kao (AceLan) Tested-by: Geert Uytterhoeven Reviewed-by: Martin K. Petersen --- drivers/ata/libata-sata.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c index a701e1538482..83a9497e48e1 100644 --- a/drivers/ata/libata-sata.c +++ b/drivers/ata/libata-sata.c @@ -1182,8 +1182,8 @@ EXPORT_SYMBOL_GPL(ata_sas_tport_delete); int ata_sas_slave_configure(struct scsi_device *sdev, struct ata_port *ap) { ata_scsi_sdev_config(sdev); - ata_scsi_dev_config(sdev, ap->link.device); - return 0; + + return ata_scsi_dev_config(sdev, ap->link.device); } EXPORT_SYMBOL_GPL(ata_sas_slave_configure);