| Message ID | 20231115193359.2262044-1-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | db80df77025ee0a5e6e089cc2f2b0c4b97867bea |
| Headers | show |
| Series | scsi: ufs: core: Warn if the request tag is truncated | expand |
Bart, > ufshcd_prepare_utp_scsi_cmd_upiu() only uses the lowest eight bits of > lrbp->task_tag. Issue a runtime warning if this results in truncation. Applied to 6.8/scsi-staging, thanks!
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index 68d7da02944f..21fe4b125081 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -2720,6 +2720,8 @@ void ufshcd_prepare_utp_scsi_cmd_upiu(struct ufshcd_lrb *lrbp, u8 upiu_flags) .command_set_type = UPIU_COMMAND_SET_TYPE_SCSI, }; + WARN_ON_ONCE(ucd_req_ptr->header.task_tag != lrbp->task_tag); + ucd_req_ptr->sc.exp_data_transfer_len = cpu_to_be32(cmd->sdb.length); cdb_len = min_t(unsigned short, cmd->cmd_len, UFS_CDB_SIZE);
ufshcd_prepare_utp_scsi_cmd_upiu() only uses the lowest eight bits of lrbp->task_tag. Issue a runtime warning if this results in truncation. Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/ufs/core/ufshcd.c | 2 ++ 1 file changed, 2 insertions(+)