| Message ID | 20240209-msm8996-fix-ufs-v1-4-107b52e57420@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | scsi: ufs: qcom: fix UFSDHCD support on MSM8996 platform | expand |
On 9.02.2024 22:50, Dmitry Baryshkov wrote: > Follow the example of other platforms and specify core_clk frequencies > in the frequency table in addition to the core_clk_src frequencies. The > driver should be setting the leaf frequency instead of some interim > clock freq. > > Suggested-by: Nitin Rawat <quic_nitirawa@quicinc.com> > Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- 3.18 says the clock can even go as high as 240000000 Konrad
On Sat, 10 Feb 2024 at 00:29, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > On 9.02.2024 22:50, Dmitry Baryshkov wrote: > > Follow the example of other platforms and specify core_clk frequencies > > in the frequency table in addition to the core_clk_src frequencies. The > > driver should be setting the leaf frequency instead of some interim > > clock freq. > > > > Suggested-by: Nitin Rawat <quic_nitirawa@quicinc.com> > > Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes") > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > 3.18 says the clock can even go as high as 240000000 Yeah. I just copied the core_clk_src specs. We can bump the clocks when this gets rewritten to use OPP tables.
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 80d83e01bb4d..401c6cce9fec 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -2072,7 +2072,7 @@ ufshc: ufshc@624000 { <&gcc GCC_UFS_RX_SYMBOL_0_CLK>; freq-table-hz = <100000000 200000000>, - <0 0>, + <100000000 200000000>, <0 0>, <0 0>, <0 0>,
Follow the example of other platforms and specify core_clk frequencies in the frequency table in addition to the core_clk_src frequencies. The driver should be setting the leaf frequency instead of some interim clock freq. Suggested-by: Nitin Rawat <quic_nitirawa@quicinc.com> Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)