| Message ID | 20240612171522.2677600-1-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] scsi: core: Fix an incorrect comment | expand |
Bart, > The comment that scsi_static_device_list would go away was added more > than 18 years ago. Today, that list is still there and a large number > of additional entries have been added. This shows that this comment is > incorrect. Hence fix that comment. Applied to 6.11/scsi-staging, thanks!
On Wed, 12 Jun 2024 10:15:21 -0700, Bart Van Assche wrote: > The comment that scsi_static_device_list would go away was added more > than 18 years ago. Today, that list is still there and a large number > of additional entries have been added. This shows that this comment is > incorrect. Hence fix that comment. > > Applied to 6.11/scsi-queue, thanks! [1/1] scsi: core: Fix an incorrect comment https://git.kernel.org/mkp/scsi/c/14d38356ec33
diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c index a7071e71389e..90f1393a23f8 100644 --- a/drivers/scsi/scsi_devinfo.c +++ b/drivers/scsi/scsi_devinfo.c @@ -39,13 +39,12 @@ static LIST_HEAD(scsi_dev_info_list); static char scsi_dev_flags[256]; /* - * scsi_static_device_list: deprecated list of devices that require - * settings that differ from the default, includes black-listed (broken) - * devices. The entries here are added to the tail of scsi_dev_info_list - * via scsi_dev_info_list_init. + * scsi_static_device_list: list of devices that require settings that differ + * from the default, includes black-listed (broken) devices. The entries here + * are added to the tail of scsi_dev_info_list via scsi_dev_info_list_init. * - * Do not add to this list, use the command line or proc interface to add - * to the scsi_dev_info_list. This table will eventually go away. + * If possible, set the BLIST_* flags from inside a SCSI LLD rather than + * adding an entry to this list. */ static struct { char *vendor;
The comment that scsi_static_device_list would go away was added more than 18 years ago. Today, that list is still there and a large number of additional entries have been added. This shows that this comment is incorrect. Hence fix that comment. Cc: Christoph Hellwig <hch@infradead.org> Cc: Avri Altman <Avri.Altman@wdc.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- Changes compared to v1: addressed Christoph's review feedback. drivers/scsi/scsi_devinfo.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)