| Message ID | 20240626180031.4050226-23-cassel@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | ata,libsas: Assign the unique id used for printing earlier | expand |
On 6/27/24 03:00, Niklas Cassel wrote: > ata_sas_port_alloc() calls ata_port_alloc() which already assigns ap->lock > so there is no need to ata_sas_port_alloc() to assign it again. Nit: s/need to/need for > > Reviewed-by: Damien Le Moal <dlemoal@kernel.org> > Signed-off-by: Niklas Cassel <cassel@kernel.org> > --- > drivers/ata/libata-sata.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c > index e7991595bfe5..1a36a5d1d7bc 100644 > --- a/drivers/ata/libata-sata.c > +++ b/drivers/ata/libata-sata.c > @@ -1228,7 +1228,6 @@ struct ata_port *ata_sas_port_alloc(struct ata_host *host, > return NULL; > > ap->port_no = 0; > - ap->lock = &host->lock; > ap->pio_mask = port_info->pio_mask; > ap->mwdma_mask = port_info->mwdma_mask; > ap->udma_mask = port_info->udma_mask;
On 6/26/24 20:00, Niklas Cassel wrote: > ata_sas_port_alloc() calls ata_port_alloc() which already assigns ap->lock > so there is no need to ata_sas_port_alloc() to assign it again. > > Reviewed-by: Damien Le Moal <dlemoal@kernel.org> > Signed-off-by: Niklas Cassel <cassel@kernel.org> > --- > drivers/ata/libata-sata.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c > index e7991595bfe5..1a36a5d1d7bc 100644 > --- a/drivers/ata/libata-sata.c > +++ b/drivers/ata/libata-sata.c > @@ -1228,7 +1228,6 @@ struct ata_port *ata_sas_port_alloc(struct ata_host *host, > return NULL; > > ap->port_no = 0; > - ap->lock = &host->lock; > ap->pio_mask = port_info->pio_mask; > ap->mwdma_mask = port_info->mwdma_mask; > ap->udma_mask = port_info->udma_mask; Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c index e7991595bfe5..1a36a5d1d7bc 100644 --- a/drivers/ata/libata-sata.c +++ b/drivers/ata/libata-sata.c @@ -1228,7 +1228,6 @@ struct ata_port *ata_sas_port_alloc(struct ata_host *host, return NULL; ap->port_no = 0; - ap->lock = &host->lock; ap->pio_mask = port_info->pio_mask; ap->mwdma_mask = port_info->mwdma_mask; ap->udma_mask = port_info->udma_mask;