diff mbox series

[2/2] mips: sgi-ip22: Fix the build

Message ID 20240805232026.65087-3-bvanassche@acm.org (mailing list archive)
State Not Applicable
Headers show
Series Fix recently introduced build failures | expand

Commit Message

Bart Van Assche Aug. 5, 2024, 11:20 p.m. UTC
Fix a recently introduced build failure.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fixes: d69d80484598 ("driver core: have match() callback in struct bus_type take a const *")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 arch/mips/sgi-ip22/ip22-gio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg Kroah-Hartman Aug. 6, 2024, 6:57 a.m. UTC | #1
On Mon, Aug 05, 2024 at 04:20:21PM -0700, Bart Van Assche wrote:
> Fix a recently introduced build failure.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Fixes: d69d80484598 ("driver core: have match() callback in struct bus_type take a const *")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>  arch/mips/sgi-ip22/ip22-gio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Thanks for this, and the other, fix, I'll queue them up to my local
trees soon.  Odd that these two targets do not seem to get any testing
in that I never was able to see them in the 0-day or other testing bots
out there.  How did you find them?

thanks,

greg k-h
Bart Van Assche Aug. 6, 2024, 8:56 p.m. UTC | #2
On 8/5/24 11:57 PM, Greg Kroah-Hartman wrote:
> On Mon, Aug 05, 2024 at 04:20:21PM -0700, Bart Van Assche wrote:
>> Fix a recently introduced build failure.
>>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Fixes: d69d80484598 ("driver core: have match() callback in struct bus_type take a const *")
>> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
>> ---
>>   arch/mips/sgi-ip22/ip22-gio.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
> 
> Thanks for this, and the other, fix, I'll queue them up to my local
> trees soon.  Odd that these two targets do not seem to get any testing
> in that I never was able to see them in the 0-day or other testing bots
> out there.  How did you find them?

Some time ago, while making changes in the SCSI core, I noticed that it
is very hard to build all SCSI drivers manually. That is why I wrote a
shell script to cross-compile all SCSI drivers. That script is available
here: 
https://github.com/bvanassche/build-scsi-drivers/blob/main/build-scsi-drivers

Thanks,

Bart.
diff mbox series

Patch

diff --git a/arch/mips/sgi-ip22/ip22-gio.c b/arch/mips/sgi-ip22/ip22-gio.c
index 2738325e98dd..d20eec742bfa 100644
--- a/arch/mips/sgi-ip22/ip22-gio.c
+++ b/arch/mips/sgi-ip22/ip22-gio.c
@@ -111,7 +111,7 @@  void gio_device_unregister(struct gio_device *giodev)
 }
 EXPORT_SYMBOL_GPL(gio_device_unregister);
 
-static int gio_bus_match(struct device *dev, struct device_driver *drv)
+static int gio_bus_match(struct device *dev, const struct device_driver *drv)
 {
 	struct gio_device *gio_dev = to_gio_device(dev);
 	struct gio_driver *gio_drv = to_gio_driver(drv);