| Message ID | 20240820123756.24590-3-quic_mapa@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | add fixup_dev_quirks vops for ufs-qcom | expand |
On 8/20/24 5:37 AM, Manish Pandey wrote: > static struct ufs_dev_quirk ufs_qcom_dev_fixups[] = { > /* add UFS device specific quirks */ > + { .wmanufacturerid = UFS_VENDOR_MICRON, > + .model = UFS_ANY_MODEL, > + .quirk = UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM }, > + { .wmanufacturerid = UFS_VENDOR_SKHYNIX, > + .model = UFS_ANY_MODEL, > + .quirk = UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM }, > {} > }; What makes these quirks specific for Qualcomm controllers? Are these quirks perhaps required for all UFSHCI controllers? Thanks, Bart.
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 290558843ca5..6d2622e79d3f 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -836,6 +836,12 @@ static int ufs_qcom_apply_dev_quirks(struct ufs_hba *hba) static struct ufs_dev_quirk ufs_qcom_dev_fixups[] = { /* add UFS device specific quirks */ + { .wmanufacturerid = UFS_VENDOR_MICRON, + .model = UFS_ANY_MODEL, + .quirk = UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM }, + { .wmanufacturerid = UFS_VENDOR_SKHYNIX, + .model = UFS_ANY_MODEL, + .quirk = UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM }, {} };
Micron and Skhynix UFS device needs DELAY_BEFORE_LPM quirk to have a delay before VCC is powered off. So add Micron and SKHYNIX vendors ID and this quirk for both devices in QCOM platforms. Signed-off-by: Manish Pandey <quic_mapa@quicinc.com> --- drivers/ufs/host/ufs-qcom.c | 6 ++++++ 1 file changed, 6 insertions(+)