| Message ID | 20240820123756.24590-4-quic_mapa@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | add fixup_dev_quirks vops for ufs-qcom | expand |
On 8/20/24 5:37 AM, Manish Pandey wrote: > + { .wmanufacturerid = UFS_VENDOR_TOSHIBA, > + .model = UFS_ANY_MODEL, > + .quirk = UFS_DEVICE_QUIRK_DELAY_AFTER_LPM }, Isn't three patches a bit much for these changes? I think all three patches can be combined into a single patch without making it harder for reviewers to understand what is going on. Thanks, Bart.
On 8/21/2024 3:05 AM, Bart Van Assche wrote: > On 8/20/24 5:37 AM, Manish Pandey wrote: >> + { .wmanufacturerid = UFS_VENDOR_TOSHIBA, >> + .model = UFS_ANY_MODEL, >> + .quirk = UFS_DEVICE_QUIRK_DELAY_AFTER_LPM }, > > Isn't three patches a bit much for these changes? I think all three > patches can be combined into a single patch without making it harder for > reviewers to understand what is going on. > > Thanks, > > Bart. > > Thanks Bart for quick review. I will merge all 3 changes to a single change in next patch set [V2]. Regards Manish
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 6d2622e79d3f..61f8c3f22ab9 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -842,6 +842,9 @@ static struct ufs_dev_quirk ufs_qcom_dev_fixups[] = { { .wmanufacturerid = UFS_VENDOR_SKHYNIX, .model = UFS_ANY_MODEL, .quirk = UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM }, + { .wmanufacturerid = UFS_VENDOR_TOSHIBA, + .model = UFS_ANY_MODEL, + .quirk = UFS_DEVICE_QUIRK_DELAY_AFTER_LPM }, {} };
Toshiba UFS devices require delay after VCC power rail is turned-off in QCOM platforms. Hence add Toshiba vendor ID and DELAY_AFTER_LPM quirk for Toshiba UFS devices in QCOM platforms. Signed-off-by: Manish Pandey <quic_mapa@quicinc.com> --- drivers/ufs/host/ufs-qcom.c | 3 +++ 1 file changed, 3 insertions(+)