diff mbox series

[v2] fusion: mptctl: Use min macro

Message ID 20240902013303.909316-1-yanzhen@vivo.com (mailing list archive)
State Accepted
Commit e88ed594328900959f8aae72c2e6240703a91f33
Headers show
Series [v2] fusion: mptctl: Use min macro | expand

Commit Message

Yan Zhen Sept. 2, 2024, 1:33 a.m. UTC 
Using the real macro is usually more intuitive and readable,
When the original file is guaranteed to contain the minmax.h header file 
and compile correctly.

Signed-off-by: Yan Zhen <yanzhen@vivo.com>
---

Changes in v2:
- Use min(variable, CONSTANT).

 drivers/message/fusion/mptctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen Sept. 13, 2024, 12:23 a.m. UTC | #1 
Yan,

> Using the real macro is usually more intuitive and readable,
> When the original file is guaranteed to contain the minmax.h header file 
> and compile correctly.

Applied to 6.12/scsi-staging, thanks!
Martin K. Petersen Sept. 19, 2024, 3:53 p.m. UTC | #2 
On Mon, 02 Sep 2024 09:33:03 +0800, Yan Zhen wrote:

> Using the real macro is usually more intuitive and readable,
> When the original file is guaranteed to contain the minmax.h header file
> and compile correctly.
> 
> 

Applied to 6.12/scsi-queue, thanks!

[1/1] fusion: mptctl: Use min macro
      https://git.kernel.org/mkp/scsi/c/e88ed5943289
diff mbox series

Patch

diff --git a/drivers/message/fusion/mptctl.c b/drivers/message/fusion/mptctl.c
index 9f3999750..17798edf7 100644
--- a/drivers/message/fusion/mptctl.c
+++ b/drivers/message/fusion/mptctl.c
@@ -1609,7 +1609,7 @@  mptctl_eventreport (MPT_ADAPTER *ioc, unsigned long arg)
 	maxEvents = numBytes/sizeof(MPT_IOCTL_EVENTS);
 
 
-	max = MPTCTL_EVENT_LOG_SIZE < maxEvents ? MPTCTL_EVENT_LOG_SIZE : maxEvents;
+	max = min(maxEvents, MPTCTL_EVENT_LOG_SIZE);
 
 	/* If fewer than 1 event is requested, there must have
 	 * been some type of error.