diff mbox series

scsi: pmcraid: Convert comma to semicolon

Message ID 20240905023521.1642862-1-nichen@iscas.ac.cn (mailing list archive)
State Accepted
Commit 4708c9332d975aabc8498ddb85936631535fdc20
Headers show
Series scsi: pmcraid: Convert comma to semicolon | expand

Commit Message

Chen Ni Sept. 5, 2024, 2:35 a.m. UTC
Replace comma between expressions with semicolons.

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/scsi/pmcraid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen Sept. 13, 2024, 12:42 a.m. UTC | #1
Chen,

> Replace comma between expressions with semicolons.

Applied to 6.12/scsi-staging, thanks!
Martin K. Petersen Sept. 19, 2024, 3:52 p.m. UTC | #2
On Thu, 05 Sep 2024 10:35:21 +0800, Chen Ni wrote:

> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> [...]

Applied to 6.12/scsi-queue, thanks!

[1/1] scsi: pmcraid: Convert comma to semicolon
      https://git.kernel.org/mkp/scsi/c/4708c9332d97
diff mbox series

Patch

diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index a2a084c8075e..8f7307c4d876 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -1946,7 +1946,7 @@  static void pmcraid_soft_reset(struct pmcraid_cmd *cmd)
 	}
 
 	iowrite32(doorbell, pinstance->int_regs.host_ioa_interrupt_reg);
-	ioread32(pinstance->int_regs.host_ioa_interrupt_reg),
+	ioread32(pinstance->int_regs.host_ioa_interrupt_reg);
 	int_reg = ioread32(pinstance->int_regs.ioa_host_interrupt_reg);
 
 	pmcraid_info("Waiting for IOA to become operational %x:%x\n",