[v2] scsi: scsi_debug: fix uninitialized variable use

Commit Message

Arnd Bergmann Feb. 25, 2025, 9:56 a.m. UTC

From: Arnd Bergmann <[e-mail]>

It appears that a typo has made it into the newly added code

drivers/scsi/scsi_debug.c:3035:3: error: variable 'len' is uninitialized when used here [-Werror,-Wuninitialized]
 3035 |                 len += resp_compression_m_pg(ap, pcontrol, target, devip->tape_dce);
      |                 ^~~

Replace the '+=' with the intended '=' here.

Fixes: 568354b24c7d ("scsi: scsi_debug: Add compression mode page for tapes")
Acked-by: Kai Mäkisara <[e-mail]>
Signed-off-by: Arnd Bergmann <[e-mail]>
---
v2: use the correct 'Fixes' tag
---
 drivers/scsi/scsi_debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen March 4, 2025, 2:01 a.m. UTC | #1

Arnd,

> It appears that a typo has made it into the newly added code
>
> drivers/scsi/scsi_debug.c:3035:3: error: variable 'len' is uninitialized when used here [-Werror,-Wuninitialized]
>  3035 |                 len += resp_compression_m_pg(ap, pcontrol, target, devip->tape_dce);
>       |                 ^~~
>
> Replace the '+=' with the intended '=' here.

Applied to 6.15/scsi-staging, thanks!

Patch

diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index 722ee8c067ae..f3e9a63bbf02 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -3032,7 +3032,7 @@  static int resp_mode_sense(struct scsi_cmnd *scp,
 	case 0xf:	/* Compression Mode Page (tape) */
 		if (!is_tape)
 			goto bad_pcode;
-		len += resp_compression_m_pg(ap, pcontrol, target, devip->tape_dce);
+		len = resp_compression_m_pg(ap, pcontrol, target, devip->tape_dce);
 		offset += len;
 		break;
 	case 0x11:	/* Partition Mode Page (tape) */