| Message ID | 20250226220414.343659-7-peter.griffin@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ufs-exynos fixes for gs101 | expand |
On 2/26/25 2:04 PM, Peter Griffin wrote: > GPIO_OUT[0] is connected to the reset pin of embedded UFS device. > Before powering off the phy assert the reset signal. Does the above apply to the GS implementation only or does it apply to all SoC's with an Exynos UFS host controller? Thanks, Bart.
Hi Bart, Thanks for the review feedback. On Fri, 28 Feb 2025 at 19:21, Bart Van Assche <bvanassche@acm.org> wrote: > > On 2/26/25 2:04 PM, Peter Griffin wrote: > > GPIO_OUT[0] is connected to the reset pin of embedded UFS device. > > Before powering off the phy assert the reset signal. > Does the above apply to the GS implementation only or does it apply to > all SoC's with an Exynos UFS host controller? The reason I went with a generic approach (rather than adding another SoC specific hook) was that exynos_ufs_dev_hw_reset() is already called by all users of this driver. From that I concluded it is a common register shared by all exynos implementations. It is hard to be 100% sure though as I don't personally have any of the other Exynos platforms supported by this driver to test on. Another approach would be to add some more gs101 SoC specific hooks for suspend() and exit() to exynos_ufs_drv_data() or another EXYNOS_UFS_OPT_. Thanks, Peter
diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index 4c3e03a3b8d9..64e2bf924213 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -1517,6 +1517,7 @@ static void exynos_ufs_exit(struct ufs_hba *hba) { struct exynos_ufs *ufs = ufshcd_get_variant(hba); + hci_writel(ufs, 0 << 0, HCI_GPIO_OUT); phy_power_off(ufs->phy); phy_exit(ufs->phy); } @@ -1700,6 +1701,8 @@ static int exynos_ufs_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op, if (status == PRE_CHANGE) return 0; + hci_writel(ufs, 0 << 0, HCI_GPIO_OUT); + if (!ufshcd_is_link_active(hba)) phy_power_off(ufs->phy);
GPIO_OUT[0] is connected to the reset pin of embedded UFS device. Before powering off the phy assert the reset signal. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- drivers/ufs/host/ufs-exynos.c | 3 +++ 1 file changed, 3 insertions(+)