| Message ID | 20250314-ufs-dma-coherent-v1-1-bdf9f9be2919@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add dma-coherent for gs101 UFS dt node | expand |
On Fri, 2025-03-14 at 15:38 +0000, Peter Griffin wrote: > ufs-exynos driver configures the sysreg shareability as > cacheable for gs101 so we need to set the dma-coherent > property so the descriptors are also allocated cacheable. > > This fixes the UFS stability issues we have seen with > the upstream UFS driver on gs101. > > Fixes: 4c65d7054b4c ("arm64: dts: exynos: gs101: Add ufs and ufs-phy dt nodes") > Cc: stable@vger.kernel.org > Suggested-by: Will McVicker <willmcvicker@google.com> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> Tested-by: André Draszik <andre.draszik@linaro.org> Reviewed-by: André Draszik <andre.draszik@linaro.org>
On 03/14/2025, Peter Griffin wrote: > ufs-exynos driver configures the sysreg shareability as > cacheable for gs101 so we need to set the dma-coherent > property so the descriptors are also allocated cacheable. > > This fixes the UFS stability issues we have seen with > the upstream UFS driver on gs101. > > Fixes: 4c65d7054b4c ("arm64: dts: exynos: gs101: Add ufs and ufs-phy dt nodes") > Cc: stable@vger.kernel.org > Suggested-by: Will McVicker <willmcvicker@google.com> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> Tested-by: Will McVicker <willmcvicker@google.com> Verified I can properly boot to Android recovery with UFS probing and mounting the partitions in the fstab. Can you send this to 6.12 stable as well since this is fixing booting issues with Android? Thanks, Will > --- > arch/arm64/boot/dts/exynos/google/gs101.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > index c5335dd59dfe9fcf8c64d66a466799600f8447b0..cf30128ef004568f01b1c7150c5585ba267d64bc 100644 > --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi > +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > @@ -1360,6 +1360,7 @@ ufs_0: ufs@14700000 { > <&cmu_hsi2 CLK_GOUT_HSI2_SYSREG_HSI2_PCLK>; > clock-names = "core_clk", "sclk_unipro_main", "fmp", > "aclk", "pclk", "sysreg"; > + dma-coherent; > freq-table-hz = <0 0>, <0 0>, <0 0>, <0 0>, <0 0>, <0 0>; > pinctrl-0 = <&ufs_rst_n &ufs_refclk_out>; > pinctrl-names = "default"; > > -- > 2.49.0.rc1.451.g8f38331e32-goog >
diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index c5335dd59dfe9fcf8c64d66a466799600f8447b0..cf30128ef004568f01b1c7150c5585ba267d64bc 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -1360,6 +1360,7 @@ ufs_0: ufs@14700000 { <&cmu_hsi2 CLK_GOUT_HSI2_SYSREG_HSI2_PCLK>; clock-names = "core_clk", "sclk_unipro_main", "fmp", "aclk", "pclk", "sysreg"; + dma-coherent; freq-table-hz = <0 0>, <0 0>, <0 0>, <0 0>, <0 0>, <0 0>; pinctrl-0 = <&ufs_rst_n &ufs_refclk_out>; pinctrl-names = "default";
ufs-exynos driver configures the sysreg shareability as cacheable for gs101 so we need to set the dma-coherent property so the descriptors are also allocated cacheable. This fixes the UFS stability issues we have seen with the upstream UFS driver on gs101. Fixes: 4c65d7054b4c ("arm64: dts: exynos: gs101: Add ufs and ufs-phy dt nodes") Cc: stable@vger.kernel.org Suggested-by: Will McVicker <willmcvicker@google.com> Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 1 + 1 file changed, 1 insertion(+)