From patchwork Wed Mar 19 10:56:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 14022470 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95D092571C8; Wed, 19 Mar 2025 10:56:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742381819; cv=none; b=BAtTunhu0ocJ3pQaEzmNrgKeJCY5zqlO7CVQ9+vZuOG4ZDz1viQEZ7h1WJSOK5peEEsUBq4N2nAz7BYsQ7tXIOkTyLrodAa3hOIx4vUmWKwRzlAdtnazMzG09GFmDOPcOoK+VF6zFx0B3xMdXqNLtWUWvWG327ZkQ/7CbbZqQzg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742381819; c=relaxed/simple; bh=hLSVkCmZq3sAZQvJDN0JoJ4G2z0ZgsLWhv3mMKL51JQ=; h=Message-ID:From:To:Cc:Subject:References:MIME-Version: Content-Type:Date; b=cSGx3wD3CkU5IeJzRM/Ugowlswl3ZcByt69AoILl+CYNHOf0C8mfqEv/w5mKPMaNGriPBT9L/bM1hCk7YG/PDJipACfEJajokQ6A+7GmkDoDGfSnIfjy7jxrlr7W9xss5lFGDt5EBV2dxK47OyAHFqzigX8CPYsvd2L41qu9vvs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=bG/x4mi2; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=7TQdxDza; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="bG/x4mi2"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="7TQdxDza" Message-ID: <20250319105506.624838146@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1742381816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=lVkhyqvX8Nx1WTN8VogxCpaEgAaZaZZ4hHPvZ1Nkv+M=; b=bG/x4mi2j7PLAIOEvQEIL2uiNI408Vb7y2bQPxAftORe42XzRMX2KgPF/MuRTfSxZAs4ZF UShesZf5jdlmDVZ9AGRd2edZFHcufYGs/INhHHvRtyMwwk72+ul/6ON+fX6HJMHG7Ti4J0 3+GtWq4cnFTwzgyOJkwOUU5fhOF/dsC3mRGaRoVxe2NX1aloDj359jry+kWsbFbCXNkEB2 Q6m8t5X6HlxTpoVflc590xSOblsHBoNGv4YAkVmnrraYATo3UD8y4URqJRJqJQYpH7e5Sc 3xFlWbuDjbPpwbjQYMMQ9kIVwasuC1/ksGRnsYDz518c0n0CYMbreahdlxp4Cw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1742381816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=lVkhyqvX8Nx1WTN8VogxCpaEgAaZaZZ4hHPvZ1Nkv+M=; b=7TQdxDzaZCmPNGySoOuULAIYOJhzDnT5up1+rHQR7uH7KkMSNdSTDaxjRdMYLbMItKzS3e UZt6RZphCDEK24Ag== From: Thomas Gleixner To: LKML Cc: Marc Zyngier , Peter Zijlstra , Jonathan Cameron , Michael Kelley , Wei Liu , Bjorn Helgaas , Haiyang Zhang , linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, Nishanth Menon , Dhruva Gole , Tero Kristo , Santosh Shilimkar , Logan Gunthorpe , Dave Jiang , Jon Mason , Allen Hubbe , ntb@lists.linux.dev, Wei Huang , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, Jonathan Cameron Subject: [patch V4 10/14] PCI: hv: Switch MSI descriptor locking to guard() References: <20250319104921.201434198@linutronix.de> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Wed, 19 Mar 2025 11:56:55 +0100 (CET) Convert the code to use the new guard(msi_descs_lock). No functional change intended. Signed-off-by: Thomas Gleixner Reviewed-by: Jonathan Cameron Reviewed-by: Michael Kelley Acked-by: Wei Liu Acked-by: Bjorn Helgaas Cc: Haiyang Zhang Cc: linux-hyperv@vger.kernel.org Cc: linux-pci@vger.kernel.org --- drivers/pci/controller/pci-hyperv.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) --- a/drivers/pci/controller/pci-hyperv.c +++ b/drivers/pci/controller/pci-hyperv.c @@ -3976,24 +3976,18 @@ static int hv_pci_restore_msi_msg(struct { struct irq_data *irq_data; struct msi_desc *entry; - int ret = 0; if (!pdev->msi_enabled && !pdev->msix_enabled) return 0; - msi_lock_descs(&pdev->dev); + guard(msi_descs_lock)(&pdev->dev); msi_for_each_desc(entry, &pdev->dev, MSI_DESC_ASSOCIATED) { irq_data = irq_get_irq_data(entry->irq); - if (WARN_ON_ONCE(!irq_data)) { - ret = -EINVAL; - break; - } - + if (WARN_ON_ONCE(!irq_data)) + return -EINVAL; hv_compose_msi_msg(irq_data, &entry->msg); } - msi_unlock_descs(&pdev->dev); - - return ret; + return 0; } /*