| Message ID | 2025450295.25603731.1459262558755.JavaMail.zimbra@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 03/29/16 07:42, Laurence Oberman wrote: > I have been using this jammer functionality to continue testing the SCSI F/C drivers and recovery for over a year now. > Any chance you would agree to ack this so I can get it in now. > I last posted to the list last March and it was not picked up. > > I did look into moving this to upper layers but I find I use it primarily for fiber channel target testing. > Attempting to add this functionality to upper layers led to complexities and this is very solid. > > This Patch diff against 4.5 > > I use target LIO for all my storage array test targets and customer problem resolution here at Red Hat. > This patch resulted from a requirement to mimic behavior of an expensive hardware jammer for a customer. > I have used this for some time with good success to simulate and reproduce latency and slow drain fabric issues and > for testing and validating error handling behavior > in the Emulex, Qlogic and other F/C drivers. > > Works by checking new parameter jam_host if its >= 0 and matches vha->host_no , jamming is enabled when jam_host >=0 > If parameter set to -1 (default) no jamming is enabled. Hello Laurence, Nic Bellinger is the maintainer of LIO so my recommendation is to ask Nic first about his opinion (I have CC'd Nic). I'm not sure what Nic thinks about this but in my opinion such functionality belongs in the target core instead of in a target driver. But please wait until Nic has provided his opinion before spending more time on this. The mailing list for SCSI target patches is target-devel@vger.kernel.org. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
(Adding target-devel + Qlogic target folks) On Tue, 2016-03-29 at 22:05 -0700, Bart Van Assche wrote: > On 03/29/16 07:42, Laurence Oberman wrote: > > I have been using this jammer functionality to continue testing the SCSI F/C drivers and recovery for over a year now. > > Any chance you would agree to ack this so I can get it in now. > > I last posted to the list last March and it was not picked up. > > > > I did look into moving this to upper layers but I find I use it primarily for fiber channel target testing. > > Attempting to add this functionality to upper layers led to complexities and this is very solid. > > > > This Patch diff against 4.5 > > > > I use target LIO for all my storage array test targets and customer problem resolution here at Red Hat. > > This patch resulted from a requirement to mimic behavior of an expensive hardware jammer for a customer. > > I have used this for some time with good success to simulate and reproduce latency and slow drain fabric issues and > > for testing and validating error handling behavior > > in the Emulex, Qlogic and other F/C drivers. > > > > Works by checking new parameter jam_host if its >= 0 and matches vha->host_no , jamming is enabled when jam_host >=0 > > If parameter set to -1 (default) no jamming is enabled. > > Hello Laurence, > > Nic Bellinger is the maintainer of LIO so my recommendation is to ask > Nic first about his opinion (I have CC'd Nic). I'm not sure what Nic > thinks about this but in my opinion such functionality belongs in the > target core instead of in a target driver. But please wait until Nic has > provided his opinion before spending more time on this. The mailing list > for SCSI target patches is target-devel@vger.kernel.org. > So really it's Himanshu's + Quinn's call if they would like to include something like this in mainline. If so, then I'd prefer to do it with a per tcm_qla2xxx_tpg endpoint attribute instead a new module parameter, and add a new kernel config option (CONFIG_TCM_QLA2XXX_DEBUG) to disable (by default) so end users don't inadvertently play with it via targetcli + friends. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Nic, Laurence, On 3/30/16, 10:34 PM, "Nicholas A. Bellinger" <nab@linux-iscsi.org> wrote: >(Adding target-devel + Qlogic target folks) > >On Tue, 2016-03-29 at 22:05 -0700, Bart Van Assche wrote: >> On 03/29/16 07:42, Laurence Oberman wrote: >> > I have been using this jammer functionality to continue testing the SCSI F/C drivers and recovery for over a year now. >> > Any chance you would agree to ack this so I can get it in now. >> > I last posted to the list last March and it was not picked up. >> > >> > I did look into moving this to upper layers but I find I use it primarily for fiber channel target testing. >> > Attempting to add this functionality to upper layers led to complexities and this is very solid. >> > >> > This Patch diff against 4.5 >> > >> > I use target LIO for all my storage array test targets and customer problem resolution here at Red Hat. >> > This patch resulted from a requirement to mimic behavior of an expensive hardware jammer for a customer. >> > I have used this for some time with good success to simulate and reproduce latency and slow drain fabric issues and >> > for testing and validating error handling behavior >> > in the Emulex, Qlogic and other F/C drivers. >> > >> > Works by checking new parameter jam_host if its >= 0 and matches vha->host_no , jamming is enabled when jam_host >=0 >> > If parameter set to -1 (default) no jamming is enabled. >> >> Hello Laurence, >> >> Nic Bellinger is the maintainer of LIO so my recommendation is to ask >> Nic first about his opinion (I have CC'd Nic). I'm not sure what Nic >> thinks about this but in my opinion such functionality belongs in the >> target core instead of in a target driver. But please wait until Nic has >> provided his opinion before spending more time on this. The mailing list >> for SCSI target patches is target-devel@vger.kernel.org. >> > >So really it's Himanshu's + Quinn's call if they would like to include >something like this in mainline. > >If so, then I'd prefer to do it with a per tcm_qla2xxx_tpg endpoint >attribute instead a new module parameter, and add a new kernel config >option (CONFIG_TCM_QLA2XXX_DEBUG) to disable (by default) so end users >don't inadvertently play with it via targetcli + friends. > I agree here with Nic. The patch does provides benefit and is good addition, but we don’t want to enable it by default. Laurence, Would you be kind to rework patch with suggested changes from Nic and post it. Thanks, Himanshu
Hello Himanshu Thanks, I will rework and post back to the thread. Thank you Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services ----- Original Message ----- From: "Himanshu Madhani" <himanshu.madhani@qlogic.com> To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>, "Bart Van Assche" <bart.vanassche@sandisk.com> Cc: "Laurence Oberman" <loberman@redhat.com>, "linux-scsi" <linux-scsi@vger.kernel.org>, "target-devel" <target-devel@vger.kernel.org>, "Quinn Tran" <quinn.tran@qlogic.com> Sent: Thursday, March 31, 2016 8:20:56 PM Subject: Re: tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module - revision3 Hi Nic, Laurence, On 3/30/16, 10:34 PM, "Nicholas A. Bellinger" <nab@linux-iscsi.org> wrote: >(Adding target-devel + Qlogic target folks) > >On Tue, 2016-03-29 at 22:05 -0700, Bart Van Assche wrote: >> On 03/29/16 07:42, Laurence Oberman wrote: >> > I have been using this jammer functionality to continue testing the SCSI F/C drivers and recovery for over a year now. >> > Any chance you would agree to ack this so I can get it in now. >> > I last posted to the list last March and it was not picked up. >> > >> > I did look into moving this to upper layers but I find I use it primarily for fiber channel target testing. >> > Attempting to add this functionality to upper layers led to complexities and this is very solid. >> > >> > This Patch diff against 4.5 >> > >> > I use target LIO for all my storage array test targets and customer problem resolution here at Red Hat. >> > This patch resulted from a requirement to mimic behavior of an expensive hardware jammer for a customer. >> > I have used this for some time with good success to simulate and reproduce latency and slow drain fabric issues and >> > for testing and validating error handling behavior >> > in the Emulex, Qlogic and other F/C drivers. >> > >> > Works by checking new parameter jam_host if its >= 0 and matches vha->host_no , jamming is enabled when jam_host >=0 >> > If parameter set to -1 (default) no jamming is enabled. >> >> Hello Laurence, >> >> Nic Bellinger is the maintainer of LIO so my recommendation is to ask >> Nic first about his opinion (I have CC'd Nic). I'm not sure what Nic >> thinks about this but in my opinion such functionality belongs in the >> target core instead of in a target driver. But please wait until Nic has >> provided his opinion before spending more time on this. The mailing list >> for SCSI target patches is target-devel@vger.kernel.org. >> > >So really it's Himanshu's + Quinn's call if they would like to include >something like this in mainline. > >If so, then I'd prefer to do it with a per tcm_qla2xxx_tpg endpoint >attribute instead a new module parameter, and add a new kernel config >option (CONFIG_TCM_QLA2XXX_DEBUG) to disable (by default) so end users >don't inadvertently play with it via targetcli + friends. > I agree here with Nic. The patch does provides benefit and is good addition, but we don’t want to enable it by default. Laurence, Would you be kind to rework patch with suggested changes from Nic and post it. Thanks, Himanshu -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Himanshu I looked at using the attribute for this but because of where I have to discard the command I dont want to have to go fetch the attribute each time in the same code path. Its significant overhead to have to go fetch the attribute value each time as I allow for a dynamic on off via the module parameter so I have to check it each command. With the module parameter its a simple compare and by having this as a module parameter its globally accessible and imposes virtually no overhead. Are you OK with me using #ifdef on the CONFIG_TCM_QLA2XXX_DEBUG .config parameter I will add here to include the module parameter and code only if set to "yes" The default unless expicitly set will be no change. Thanks Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services ----- Original Message ----- From: "Himanshu Madhani" <himanshu.madhani@qlogic.com> To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>, "Bart Van Assche" <bart.vanassche@sandisk.com> Cc: "Laurence Oberman" <loberman@redhat.com>, "linux-scsi" <linux-scsi@vger.kernel.org>, "target-devel" <target-devel@vger.kernel.org>, "Quinn Tran" <quinn.tran@qlogic.com> Sent: Thursday, March 31, 2016 8:20:56 PM Subject: Re: tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module - revision3 Hi Nic, Laurence, On 3/30/16, 10:34 PM, "Nicholas A. Bellinger" <nab@linux-iscsi.org> wrote: >(Adding target-devel + Qlogic target folks) > >On Tue, 2016-03-29 at 22:05 -0700, Bart Van Assche wrote: >> On 03/29/16 07:42, Laurence Oberman wrote: >> > I have been using this jammer functionality to continue testing the SCSI F/C drivers and recovery for over a year now. >> > Any chance you would agree to ack this so I can get it in now. >> > I last posted to the list last March and it was not picked up. >> > >> > I did look into moving this to upper layers but I find I use it primarily for fiber channel target testing. >> > Attempting to add this functionality to upper layers led to complexities and this is very solid. >> > >> > This Patch diff against 4.5 >> > >> > I use target LIO for all my storage array test targets and customer problem resolution here at Red Hat. >> > This patch resulted from a requirement to mimic behavior of an expensive hardware jammer for a customer. >> > I have used this for some time with good success to simulate and reproduce latency and slow drain fabric issues and >> > for testing and validating error handling behavior >> > in the Emulex, Qlogic and other F/C drivers. >> > >> > Works by checking new parameter jam_host if its >= 0 and matches vha->host_no , jamming is enabled when jam_host >=0 >> > If parameter set to -1 (default) no jamming is enabled. >> >> Hello Laurence, >> >> Nic Bellinger is the maintainer of LIO so my recommendation is to ask >> Nic first about his opinion (I have CC'd Nic). I'm not sure what Nic >> thinks about this but in my opinion such functionality belongs in the >> target core instead of in a target driver. But please wait until Nic has >> provided his opinion before spending more time on this. The mailing list >> for SCSI target patches is target-devel@vger.kernel.org. >> > >So really it's Himanshu's + Quinn's call if they would like to include >something like this in mainline. > >If so, then I'd prefer to do it with a per tcm_qla2xxx_tpg endpoint >attribute instead a new module parameter, and add a new kernel config >option (CONFIG_TCM_QLA2XXX_DEBUG) to disable (by default) so end users >don't inadvertently play with it via targetcli + friends. > I agree here with Nic. The patch does provides benefit and is good addition, but we don’t want to enable it by default. Laurence, Would you be kind to rework patch with suggested changes from Nic and post it. Thanks, Himanshu N?????r??y???b?X???v?^?)?{.n?+????{???"?{ay????,j??f???h???z??w??????j:+v???w?j?m????????zZ+???j"?? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff -Nurp linux-4.5.orig/Documentation/scsi/tcm_qla2xxx.txt linux-4.5/Documentation/scsi/tcm_qla2xxx.txt --- linux-4.5.orig/Documentation/scsi/tcm_qla2xxx.txt 1969-12-31 19:00:00.000000000 -0500 +++ linux-4.5/Documentation/scsi/tcm_qla2xxx.txt 2016-03-29 10:08:57.455761389 -0400 @@ -0,0 +1,31 @@ +tcm_qla2xxx jammer parameter usage +---------------------------------- +There is now a new module parameter added to the tcm_qla2xx module +parm: jam_host:Host to jam >=0 Enable jammer (int) + +Use this parameter to control the discarding of SCSI commands to a selected +host. +This may be useful for testing error handling and simulating slow drain +and other fabric issues. + +Any value >=0 that matches a fc_host # will discard the commands for that host. +Reset back to -1 to stop the jamming. + +Enable host 6 to be jammed +echo 6 > /sys/module/tcm_qla2xxx/parameters/jam_host + +Disable jamming on host 6 +echo -1 > /sys/module/tcm_qla2xxx/parameters/jam_host + +Usage example script: + +#!/bin/bash +sleep_time=120 ### Time to jam for +echo 6 > /sys/module/tcm_qla2xxx/parameters/jam_host +host=`cat /sys/module/tcm_qla2xxx/parameters/jam_host` +echo "We start to discard commands on SCSI host $host" +logger "Jammer started" +sleep $sleep_time +echo -1 > /sys/module/tcm_qla2xxx/parameters/jam_host +echo "We stopped the jammer" +logger "Jammer stopped" diff -Nurp linux-4.5.orig/drivers/scsi/qla2xxx/tcm_qla2xxx.c linux-4.5/drivers/scsi/qla2xxx/tcm_qla2xxx.c --- linux-4.5.orig/drivers/scsi/qla2xxx/tcm_qla2xxx.c 2016-03-14 00:28:54.000000000 -0400 +++ linux-4.5/drivers/scsi/qla2xxx/tcm_qla2xxx.c 2016-03-29 10:10:09.677298099 -0400 @@ -48,6 +48,10 @@ #include "qla_target.h" #include "tcm_qla2xxx.h" +int jam_host = -1; +module_param(jam_host, int, 0644); +MODULE_PARM_DESC(jam_host, "Host to jam >=0 Enable jammer"); + static struct workqueue_struct *tcm_qla2xxx_free_wq; static struct workqueue_struct *tcm_qla2xxx_cmd_wq; @@ -477,6 +481,11 @@ static int tcm_qla2xxx_handle_cmd(scsi_q return -EINVAL; } + if (unlikely(vha->host_no == jam_host)) { + /* return, and dont run target_submit_cmd,discarding command */ + return 0; + } + cmd->vha->tgt_counters.qla_core_sbt_cmd++; return target_submit_cmd(se_cmd, se_sess, cdb, &cmd->sense_buffer[0], cmd->unpacked_lun, data_length, fcp_task_attr, @@ -1967,6 +1976,7 @@ static void tcm_qla2xxx_deregister_confi static int __init tcm_qla2xxx_init(void) { int ret; + jam_host = -1; ret = tcm_qla2xxx_register_configfs(); if (ret < 0)
Hello Bart, I have been using this jammer functionality to continue testing the SCSI F/C drivers and recovery for over a year now. Any chance you would agree to ack this so I can get it in now. I last posted to the list last March and it was not picked up. I did look into moving this to upper layers but I find I use it primarily for fiber channel target testing. Attempting to add this functionality to upper layers led to complexities and this is very solid. This Patch diff against 4.5 I use target LIO for all my storage array test targets and customer problem resolution here at Red Hat. This patch resulted from a requirement to mimic behavior of an expensive hardware jammer for a customer. I have used this for some time with good success to simulate and reproduce latency and slow drain fabric issues and for testing and validating error handling behavior in the Emulex, Qlogic and other F/C drivers. Works by checking new parameter jam_host if its >= 0 and matches vha->host_no , jamming is enabled when jam_host >=0 If parameter set to -1 (default) no jamming is enabled. Tested by: Laurence Oberman <loberman@redhat.com> Signed-off-by: Laurence Oberman <loberman@redhat.com> Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html