From patchwork Tue Aug 4 09:57:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anil Gurumurthy X-Patchwork-Id: 6936001 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CB7639F373 for ; Tue, 4 Aug 2015 09:59:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2935020429 for ; Tue, 4 Aug 2015 09:59:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F11D2041E for ; Tue, 4 Aug 2015 09:59:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933131AbbHDJ7J (ORCPT ); Tue, 4 Aug 2015 05:59:09 -0400 Received: from mx0a-0016ce01.pphosted.com ([67.231.148.157]:33653 "EHLO mx0a-0016ce01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933026AbbHDJ5S (ORCPT ); Tue, 4 Aug 2015 05:57:18 -0400 Received: from pps.filterd (m0045602.ppops.net [127.0.0.1]) by mx0a-0016ce01.pphosted.com (8.15.0.59/8.15.0.59) with SMTP id t749qGZZ015547 for ; Tue, 4 Aug 2015 02:57:18 -0700 Received: from avcashub1.qlogic.com (avcashub1.qlogic.com [198.70.193.115]) by mx0a-0016ce01.pphosted.com with ESMTP id 1w2kktrgh8-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT) for ; Tue, 04 Aug 2015 02:57:18 -0700 Received: from AVMB2.qlogic.org ([fe80::cdfd:9ba8:5afa:475c]) by avcashub1.qlogic.org ([::1]) with mapi id 14.03.0235.001; Tue, 4 Aug 2015 02:57:17 -0700 From: Anil Gurumurthy To: Colin King , Sudarsana Kalluru , "James E.J. Bottomley" , linux-scsi CC: linux-kernel Subject: RE: [PATCH] [SCSI] bfa: fix missing { } braces Thread-Topic: [PATCH] [SCSI] bfa: fix missing { } braces Thread-Index: AQHQzfm06l3yECNDMk2SmuQpnGxNXZ37m7TQ Date: Tue, 4 Aug 2015 09:57:11 +0000 Message-ID: <20B1A3CBD98F3845B3F5F56D8597EF5901037771@avmb2.qlogic.org> References: <1438612527-3707-1-git-send-email-colin.king@canonical.com> In-Reply-To: <1438612527-3707-1-git-send-email-colin.king@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: <20B1A3CBD98F3845B3F5F56D8597EF5901037771@avmb2.qlogic.org> x-originating-ip: [10.1.4.10] disclaimer: bypass MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5700 definitions=7882 signatures=670618 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1506180000 definitions=main-1508040165 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Colin, We will fix the indentation in the next set of patches that we submit upstream. Thanks, Anil -----Original Message----- From: Colin King [mailto:colin.king@canonical.com] Sent: 03 August 2015 20:05 To: Anil Gurumurthy; Sudarsana Kalluru; James E.J. Bottomley; linux-scsi Cc: linux-kernel Subject: [PATCH] [SCSI] bfa: fix missing { } braces From: Colin Ian King Static analysis by smatch indicated that there was a curly braces issue: drivers/scsi/bfa/bfa_ioc.c:3668 bfa_cb_sfp_state_query() warn: curly braces intended? drivers/scsi/bfa/bfa_ioc.c:3671 bfa_cb_sfp_state_query() warn: inconsistent indenting drivers/scsi/bfa/bfa_ioc.c:3676 bfa_cb_sfp_state_query() warn: curly braces intended? The fix matches the intended logic based on the original indentation layout of the code. Signed-off-by: Colin Ian King --- drivers/scsi/bfa/bfa_ioc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.5.0 diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c index 315d6d6..59c3492 100644 --- a/drivers/scsi/bfa/bfa_ioc.c +++ b/drivers/scsi/bfa/bfa_ioc.c @@ -3662,7 +3662,7 @@ bfa_cb_sfp_state_query(struct bfa_sfp_s *sfp) bfa_trc(sfp, sfp->portspeed); if (sfp->media) { bfa_sfp_media_get(sfp); - if (sfp->state_query_cbfn) + if (sfp->state_query_cbfn) { sfp->state_query_cbfn(sfp->state_query_cbarg, sfp->status); sfp->media = NULL; @@ -3670,14 +3670,16 @@ bfa_cb_sfp_state_query(struct bfa_sfp_s *sfp) if (sfp->portspeed) { sfp->status = bfa_sfp_speed_valid(sfp, sfp->portspeed); - if (sfp->state_query_cbfn) + if (sfp->state_query_cbfn) { sfp->state_query_cbfn(sfp->state_query_cbarg, sfp->status); sfp->portspeed = BFA_PORT_SPEED_UNKNOWN; + } } sfp->state_query_lock = 0; sfp->state_query_cbfn = NULL; + } } /*