From patchwork Tue Aug 29 22:00:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBNaXJvc8WCYXc=?= X-Patchwork-Id: 9928389 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9559F602B9 for ; Tue, 29 Aug 2017 22:00:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8711528AA0 for ; Tue, 29 Aug 2017 22:00:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7B41628A99; Tue, 29 Aug 2017 22:00:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0957828AA2 for ; Tue, 29 Aug 2017 22:00:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751662AbdH2WAS (ORCPT ); Tue, 29 Aug 2017 18:00:18 -0400 Received: from 78-11-180-123.static.ip.netia.com.pl ([78.11.180.123]:55376 "EHLO rere.qmqm.pl" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751492AbdH2WAR (ORCPT ); Tue, 29 Aug 2017 18:00:17 -0400 Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 3xhjHM6YfLzZ; Wed, 30 Aug 2017 00:00:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1504044016; bh=mOUmqIq3U2JsAgg01rPgsYpBjWsReM792syyWV49LyM=; h=Date:From:Subject:To:Cc:From; b=Kj8W3gSa+sfPQd/zXrEKYhS23WMgeAVdjeWhPtTQMiWFnPhXiUL7sizfMFy9zGz08 nQ2IXroiWSnv4HEG9ocOo3oHdZZGbXjTr5W2vE8JePgqehWBFp3mQEWtnjSE3iQN7J mHViczSKyD5F1kBefigOR9q/cBYyKhyTUVuL5RauAsmIE6sdx8/Zg136d+L/YEVUgl 2xot/SffDYr1Vn0pJixDgsMrtW8Y4L289FWiTNnSbQ8R2DwajE0Xf14UNxd2o6qmTv 12qKx7pU2eNt6+BXH4SFYxtGqwQCiA9zTb7/aeIaGzepcB39jlPVjhIv7qP2/zM0mA 78y/cOSkIIorw== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.99.2 at rere Date: Wed, 30 Aug 2017 00:00:15 +0200 Message-Id: <29ebd092338f51b297e94510d88892492ee3b690.1504043937.git.mirq-linux@rere.qmqm.pl> From: =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Subject: [PATCH] scsi: sd: make disk spin-up quieter MIME-Version: 1.0 To: "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently disk spin-up is generating one line per second. Make it less verbose by setting DEBUG level for progress indicators. Add device id prefixes while at it. Signed-off-by: Michał Mirosław --- drivers/scsi/sd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index b6bb4e0ce0e3..7544b60e5a6d 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -2117,7 +2117,7 @@ sd_spinup_disk(struct scsi_disk *sdkp) } /* Wait 1 second for next try */ msleep(1000); - printk("."); + sd_printk(KERN_DEBUG, sdkp, "."); /* * Wait for USB flash devices with slow firmware. @@ -2147,9 +2147,9 @@ sd_spinup_disk(struct scsi_disk *sdkp) if (spintime) { if (scsi_status_is_good(the_result)) - printk("ready\n"); + sd_printk(KERN_NOTICE, sdkp, "disk is ready\n"); else - printk("not responding...\n"); + sd_printk(KERN_NOTICE, sdkp, "disk not responding...\n"); } }