| Message ID | 307F48E420013C4E85C75C93E532197AB809206B@BBYEXM01.pmc-sierra.internal (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 03/17/2015 04:28 PM, Achim Leubner wrote: > Reviewed-by: Achim Leubner <Achim.Leubner@pmcs.com> > > > -----Original Message----- > From: Mahesh Rajashekhara > Sent: Wednesday, March 4, 2015 9:39 AM > To: JBottomley@Parallels.com; linux-scsi@vger.kernel.org > Cc: aacraid@pmc-sierra.com; Harry Yang; Achim Leubner; Rajinikanth Pandurangan; Rich Bono; Mahesh Rajashekhara > Subject: [PATCH 7/7] aacraid: AIF raw device remove support > > Add AIF raw device remove support > > Signed-off-by: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com> Reviewed-by: Hannes Reinecke <hare@suse.de> But please split off the unrelated patches from the VPD support one. And I would recommend to split off the version increase into a separate one, too, to be applied at the end. Otherwise it'll be hard to track which patches belong to which version. Cheers, Hannes
Thanks for your review comments. I have prepared V2 patch set and in which I have taken care all your review comments. Regards, Mahesh -----Original Message----- From: Hannes Reinecke [mailto:hare@suse.de] Sent: Wednesday, March 18, 2015 4:59 PM To: Achim Leubner; Mahesh Rajashekhara; JBottomley@Parallels.com; linux-scsi@vger.kernel.org Subject: Re: [PATCH 7/7] aacraid: AIF raw device remove support On 03/17/2015 04:28 PM, Achim Leubner wrote: > Reviewed-by: Achim Leubner <Achim.Leubner@pmcs.com> > > > -----Original Message----- > From: Mahesh Rajashekhara > Sent: Wednesday, March 4, 2015 9:39 AM > To: JBottomley@Parallels.com; linux-scsi@vger.kernel.org > Cc: aacraid@pmc-sierra.com; Harry Yang; Achim Leubner; Rajinikanth > Pandurangan; Rich Bono; Mahesh Rajashekhara > Subject: [PATCH 7/7] aacraid: AIF raw device remove support > > Add AIF raw device remove support > > Signed-off-by: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com> Reviewed-by: Hannes Reinecke <hare@suse.de> But please split off the unrelated patches from the VPD support one. And I would recommend to split off the version increase into a separate one, too, to be applied at the end. Otherwise it'll be hard to track which patches belong to which version. Cheers, Hannes
diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h index 74a0440..5aaa9a6 100644 --- a/drivers/scsi/aacraid/aacraid.h +++ b/drivers/scsi/aacraid/aacraid.h @@ -2061,6 +2061,9 @@ extern struct aac_common aac_config; /* PMC NEW COMM: Request the event data */ #define AifReqEvent 200 +/* RAW device deleted */ +#define AifRawDeviceRemove 203 + /* * Adapter Initiated FIB command structures. Start with the adapter * initiated FIBs that really come from the adapter, and get responded diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c index 0555023..8bb9ee4 100644 --- a/drivers/scsi/aacraid/commsup.c +++ b/drivers/scsi/aacraid/commsup.c @@ -884,6 +884,38 @@ static void aac_handle_aif(struct aac_dev * dev, struct fib * fibptr) switch (le32_to_cpu(aifcmd->command)) { case AifCmdDriverNotify: switch (le32_to_cpu(((__le32 *)aifcmd->data)[0])) { + case AifRawDeviceRemove: + container = le32_to_cpu(((__le32 *)aifcmd->data)[1]); + if ((container >> 28)) { + container = (u32)-1; + break; + } + channel = (container >> 24) & 0xF; + if (channel >= dev->maximum_num_channels) { + container = (u32)-1; + break; + } + id = container & 0xFFFF; + if (id >= dev->maximum_num_physicals) { + container = (u32)-1; + break; + } + lun = (container >> 16) & 0xFF; + container = (u32)-1; + channel = aac_phys_to_logical(channel); + device_config_needed = + (((__le32 *)aifcmd->data)[0] == + cpu_to_le32(AifRawDeviceRemove)) ? DELETE : ADD; + + if (device_config_needed == ADD) { + device = scsi_device_lookup(dev->scsi_host_ptr, channel, id, lun); + if (device) { + scsi_remove_device(device); + scsi_device_put(device); + } + } + break; + /* * Morph or Expand complete */