[v2] scsi: logging: update description of logging_level bits

Commit Message

Randy Dunlap Oct. 11, 2017, 5:09 p.m. UTC

From: Randy Dunlap <[e-mail]>

Update the description of 'scsi_logging_level' from 8 4-bit nibbles
to the (pre-git) reality of 10 3-bit bitfields.

Signed-off-by: Randy Dunlap <[e-mail]>
Reviewed-by: Kyle Fortin <[e-mail]>
Reviewed-by: Steffen Maier <[e-mail]>
---
 drivers/scsi/scsi_logging.h |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

v2: change 3-bit 'nibbles' to 3-bit bitfields.
    add Reviewed-bys.

Comments

Kyle Fortin Oct. 11, 2017, 5:11 p.m. UTC | #1

Looks good.

Reviewed-by: Kyle Fortin <[e-mail]>

Martin K. Petersen Oct. 11, 2017, 6:22 p.m. UTC | #2

Randy,

> Update the description of 'scsi_logging_level' from 8 4-bit nibbles
> to the (pre-git) reality of 10 3-bit bitfields.

Applied to 4.15/scsi-queue. Thank you!

Patch

--- lnx-414-rc3.orig/drivers/scsi/scsi_logging.h
+++ lnx-414-rc3/drivers/scsi/scsi_logging.h
@@ -3,10 +3,10 @@ 
 
 
 /*
- * This defines the scsi logging feature.  It is a means by which the user
- * can select how much information they get about various goings on, and it
- * can be really useful for fault tracing.  The logging word is divided into
- * 8 nibbles, each of which describes a loglevel.  The division of things is
+ * This defines the scsi logging feature.  It is a means by which the user can
+ * select how much information they get about various goings on, and it can be
+ * really useful for fault tracing.  The logging word is divided into 10 3-bit
+ * bitfields, each of which describes a loglevel.  The division of things is
  * somewhat arbitrary, and the division of the word could be changed if it
  * were really needed for any reason.  The numbers below are the only place
  * where these are specified.  For a first go-around, 3 bits is more than