| Message ID | 41c86e7e3e05a13bd586d8ee1b81296140b7a6eb.1637961191.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/3] scsi: hisi_sas: Use devm_bitmap_zalloc() when applicable | expand |
On 26/11/2021 21:18, Christophe JAILLET wrote: > The 'hisi_hba->slot_index_tags' bitmap is allocated with 'bitmap_zalloc()' > so it is already cleared. > > There is no need to clear it another time, one bit at a time. > > So, remove the corresponding useless code. > > Signed-off-by: Christophe JAILLET<christophe.jaillet@wanadoo.fr> Acked-by: John Garry <john.garry@huawei.com>
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c index 6ecb42d5ce81..d4f5d093bde4 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_main.c +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c @@ -206,14 +206,6 @@ static int hisi_sas_slot_index_alloc(struct hisi_hba *hisi_hba, return index; } -static void hisi_sas_slot_index_init(struct hisi_hba *hisi_hba) -{ - int i; - - for (i = 0; i < hisi_hba->slot_index_count; ++i) - hisi_sas_slot_index_clear(hisi_hba, i); -} - void hisi_sas_slot_task_free(struct hisi_hba *hisi_hba, struct sas_task *task, struct hisi_sas_slot *slot) { @@ -2535,7 +2527,6 @@ int hisi_sas_alloc(struct hisi_hba *hisi_hba) if (!hisi_hba->sata_breakpoint) goto err_out; - hisi_sas_slot_index_init(hisi_hba); hisi_hba->last_slot_index = HISI_SAS_UNRESERVED_IPTT; hisi_hba->wq = create_singlethread_workqueue(dev_name(dev));
The 'hisi_hba->slot_index_tags' bitmap is allocated with 'bitmap_zalloc()' so it is already cleared. There is no need to clear it another time, one bit at a time. So, remove the corresponding useless code. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/scsi/hisi_sas/hisi_sas_main.c | 9 --------- 1 file changed, 9 deletions(-)