From patchwork Fri Oct 16 12:13:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7414351 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1ABD99F1D5 for ; Fri, 16 Oct 2015 12:14:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2609B20A64 for ; Fri, 16 Oct 2015 12:14:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 27ED620790 for ; Fri, 16 Oct 2015 12:14:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932117AbbJPMOZ (ORCPT ); Fri, 16 Oct 2015 08:14:25 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:57158 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932101AbbJPMOY (ORCPT ); Fri, 16 Oct 2015 08:14:24 -0400 Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue002) with ESMTPSA (Nemesis) id 0MKhPD-1ZozR61vPT-001wIw; Fri, 16 Oct 2015 14:13:55 +0200 From: Arnd Bergmann To: linux-scsi@vger.kernel.org, James Bottomley Cc: Hannes Reinecke , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] scsi: advansys needs ISA dma api for ISA support Date: Fri, 16 Oct 2015 14:13:53 +0200 Message-ID: <4351271.eUtUWpTn54@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:rrkh8ONoXGFf4JcRq/ly59cTJoSuB9l1L136i2k8KlGSe2Y9NNd Y0W8dt7FDilVde4EHudmWfKnjmhw1/zwzp4uRmLWoaeoeutd6RQMiC6osEbE9TwN1rolpnS g12sYue6CY+BQprjAuAN3qfRxIrHHl7UgLahM+oWhuIkVcmQVivUuD1Gy2TWLnIDbNen23k DxBuGsTsNfS3Bc1RgBWrA== X-UI-Out-Filterresults: notjunk:1; V01:K0:9agnswhYDyU=:CW4W2wDd0RcpQpTpHWQACf nTP9in4hi510JPJwH9WHVk+SZzMKUA2K8KYdu3qJ05ggPWDoEA5vyqerUNPS5sqr/1TkMaFrw o07jxCy3QFJBYP0Cgas552G1U6eI7xCzeF1R/87tGuPvXqfIiG8J03Im0fjcCYEhwCjyrx98s L8EkMUxKYl0xCoBtQM2xsWCKsvStIbCZt0NpMZBidaw5BHeT/ZtAlGgOFRaLoHtj5/sbpN9HH jkfWHezAR+M5jw36lXwwP5r6dsXNwUy7H0557sBfWoMi+Un0/6wk4+kZDBBiuWJex4NjXYRLM 6z6u5o8kX3zNbCUyXcHSVq3/hBsKTEVox8cABord3mJZsJ+5h/tRPnqFkXiMH7FDR72eUYnKd f9jKbKRNQ6Xq0wu3DAaT0h5VJgfNY+ueJHpacLm4a+F7Uu+DA6NcUF3OBwnL0zg1SbQmEWwmL 0JqhaTriP9SKekhEx3W8nxpkscRw56AAPwTXNsIb2WJNhOwdYCGIDxwpOwMsY6k0l0Fqd1evz agsJSyV8NdyF3JiZ0FdexAeE/+usianPUVlpWdQbxNlqD6OJm9Jm+MGUEJftKOUsjzgKCXpdQ nffER3LPjPDnlKtCpXIEJJuPs3NFOYn66S8qveMq3cm7PY4XZmwI3ga88y8FCWHR8Om8l4f1l bzzKOfVz7/Gv1P618QOlfxyLszShcsB4RargC6cSXQyl0gfs+fc5hB9ESJR9RiJR9RpQKJPJE ypJnjzb73LxCZJgs Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The advansys drvier uses the request_dma function that is used on ISA machines for the internal DMA controller, which causes build errors on platforms that have ISA slots but do not provide the ISA DMA API: drivers/scsi/advansys.c: In function 'advansys_board_found': drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration] The problem now showed up in ARM randconfig builds after commit 6571fb3f8b7f ("advansys: Update to version 3.5 and remove compilation warning") made it possible to build on platforms that have neither VIRT_TO_BUS nor ISA_DMA_API but that do have ISA. This adds a dependency to only build the driver on ISA based machines if they also support ISA_DMA_API, or if they EISA or PCI are also enabled. Signed-off-by: Arnd Bergmann Reviewed-by: Hannes Reinecke --- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index d2f480b04a52..1d8b8257773d 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -498,7 +498,7 @@ config SCSI_DPT_I2O config SCSI_ADVANSYS tristate "AdvanSys SCSI support" depends on SCSI - depends on ISA || EISA || PCI + depends on (ISA && ISA_DMA_API) || EISA || PCI help This is a driver for all SCSI host adapters manufactured by AdvanSys. It is documented in the kernel source in