From patchwork Wed Nov 9 00:20:20 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kashyap Desai X-Patchwork-Id: 9418253 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E8DAC6022E for ; Wed, 9 Nov 2016 00:20:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D8E5F28934 for ; Wed, 9 Nov 2016 00:20:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CA57628A02; Wed, 9 Nov 2016 00:20:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E861B28934 for ; Wed, 9 Nov 2016 00:20:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752583AbcKIAUY (ORCPT ); Tue, 8 Nov 2016 19:20:24 -0500 Received: from mail-it0-f53.google.com ([209.85.214.53]:35564 "EHLO mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989AbcKIAUX (ORCPT ); Tue, 8 Nov 2016 19:20:23 -0500 Received: by mail-it0-f53.google.com with SMTP id e187so181578200itc.0 for ; Tue, 08 Nov 2016 16:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=dIFNML3FcoeNhx61I/WZhlQzQD91C6IlUQvXXV1mBag=; b=e//xBk+v6qSc0ivtTL7jhEFIv/nPkriapWT5sMYpvLjo9sx8ouqh372XfqalFB+tVN sf3yVxbXrKRJvr7V7WP+J16jB2NG75d5GuLZkedzdnChljUBw2/DFc4WdKVMCUL4Oe0P V+CDW9h4QzN8QL9Og+FeJ7PrzAUf4oTpg9s+M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=dIFNML3FcoeNhx61I/WZhlQzQD91C6IlUQvXXV1mBag=; b=fF3IyGlIperyqIFS4IX/PAEzlR4+cjzmKrbIR7aJ0g7aZJou6ntiqGBYWF1z5f16qn aXPrTl8O8O5DRVyehZhbyR5EvdM1OdFqLo/75JhiCBeiNaSXqu2c5Lr5LqYmw2bE96mB JbLDe1A/T6NTZsCPGZrwC24LHBTqY5Ac8FgcyN4sOR5KPJFmGaJeULWwh3f+sJ9OtNXH bzAyuJUxwZ+c+Y3gSOPqm/xUx55UcPgIMmUckenkDug9LAAbIQgnM6hQ6ziIcy1/2S2Q yVub7gD2thrq/VkSKQyQQOoDXVE55aZa0k3yZBkSvI5gOGeX542p/ah+fJcGXDwj28WL BPhw== X-Gm-Message-State: ABUngvcgBTmMrpfsAamm1MpEqoWF3RoJx4fl8Oi2oC3WZrpL8fwhNBZwPLDhA+WsAKT4uXYPrFWd1lhjEeyr6omL X-Received: by 10.36.178.12 with SMTP id u12mr11778794ite.36.1478650822626; Tue, 08 Nov 2016 16:20:22 -0800 (PST) From: Kashyap Desai References: In-Reply-To: MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQG8TG79NQKlKo6UcaJ08wcey0ef9wJgJa+BoOiiBRA= Date: Wed, 9 Nov 2016 05:50:20 +0530 Message-ID: <48f84d6c60f7ac70928c2cb34cd2ed1f@mail.gmail.com> Subject: RE: [REGRESSION] 4.9-rc4+ doesn't boot on my test box To: "Martin K. Petersen" , Jens Axboe Cc: linux-scsi Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP > -----Original Message----- > From: Martin K. Petersen [mailto:martin.petersen@oracle.com] > Sent: Wednesday, November 09, 2016 4:45 AM > To: Jens Axboe > Cc: linux-scsi; Kashyap Desai; Martin K. Petersen > Subject: Re: [REGRESSION] 4.9-rc4+ doesn't boot on my test box > > >>>>> "Jens" == Jens Axboe writes: > > Jens> I wasted half a day on this, thinking it was something in my > Jens> 4.10 branches. But it turns out it is not, the regression is in > Jens> mainline. Jens - Sorry for trouble. I did not validated this single patch. I validated complete patch set. Issue is improper MACRO usage MEGASAS_IS_LOGICAL, which gives incorrect check condition in qcmd Path. Below is proposed fix. (((scp->device->channel % 2) * MEGASAS_MAX_DEV_PER_CHANNEL) + \ > > Kashyap, have you tested the stable fix without the remainder of the driver > update in place? Martin - I validated whole series. Apologies for this. Please help me to know how to fix this ? Do I need to send only fix on top of latest commit (as posted above - MACRO definition) for this issue ? > > -- > Martin K. Petersen Oracle Linux Engineering --- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h index 74c7b44..0d2625b 100644 --- a/drivers/scsi/megaraid/megaraid_sas.h +++ b/drivers/scsi/megaraid/megaraid_sas.h @@ -2236,7 +2236,7 @@ struct megasas_instance_template { }; #define MEGASAS_IS_LOGICAL(scp) \ - (scp->device->channel < MEGASAS_MAX_PD_CHANNELS) ? 0 : 1 + ((scp->device->channel < MEGASAS_MAX_PD_CHANNELS) ? 0 : 1) #define MEGASAS_DEV_INDEX(scp) \