From patchwork Sun Aug 21 07:22:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9292049 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 172B0607F0 for ; Sun, 21 Aug 2016 07:23:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0293028BB0 for ; Sun, 21 Aug 2016 07:23:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E9D7728BB2; Sun, 21 Aug 2016 07:23:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E05F128BB0 for ; Sun, 21 Aug 2016 07:23:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752165AbcHUHXR (ORCPT ); Sun, 21 Aug 2016 03:23:17 -0400 Received: from mout.web.de ([212.227.17.11]:53292 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751564AbcHUHXQ (ORCPT ); Sun, 21 Aug 2016 03:23:16 -0400 Received: from [192.168.1.3] ([77.181.85.179]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0Martm-1brG3R1lpy-00KQrG; Sun, 21 Aug 2016 09:23:03 +0200 Subject: [PATCH 3/7] aacraid: Delete unnecessary initialisations in aac_send_raw_srb() To: linux-scsi@vger.kernel.org, aacraid@microsemi.com, "James E. J. Bottomley" , "Martin K. Petersen" References: <566ABCD9.1060404@users.sourceforge.net> <40d8607f-3934-c31f-3791-ef6a67d65d45@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <4d56e32b-3a42-8bcf-29e9-c000922b14cb@users.sourceforge.net> Date: Sun, 21 Aug 2016 09:22:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <40d8607f-3934-c31f-3791-ef6a67d65d45@users.sourceforge.net> X-Provags-ID: V03:K0:HWkNonNdWF571wc77dF3g96il76lduPeqse9clZyPR9f+eKSugo AqZvKpHbnSRtwWVXAI1TyiQJVEfo29kwFjph8xska6MP2+KP6FRIurNUa844Np29cNThwWg +lQNsRbHujDg5Q3y4wHJHUTEwSOmANR4KyDhOlujwjfA/NcFkCvhlrueVDRYK6OJtM6+fPl ovTkn6d4ObtILKhlqkkSg== X-UI-Out-Filterresults: notjunk:1; V01:K0:SIBNnbjiMA0=:s9tMxw6ufMw46ze1ktOYZU l5we7guNJMVdPG9kmJNQead3bmwdcgKyFffNHFkpTZoISGMOeqtRQOKGaVMKEX/COVpDBEc/7 l5a/BwN+bhBIl6VgUrYQkKg5+lBiB1eYPRqj2x6SvG+q+W4M/mzncj8tbYw9ir1vslGyJDmVH x0xWYf9VNBa42dYcL7i8WZFTn3yULgGRpZHTqh3uGL5ysKnxWnbiFDoq/l4NfSOblUuMp+QWi cdJSdR1B5yOEatjj3gJlOmrEAD5foIc9tF4Zx/PI6SEKfBpHBl5RZkd0BN6/yaXOdWTAsp8sD +vJ4mcMwOm3HwaAsMhLP6eU8gQx9XUlxcN14vkyRd2GxQywtpNlTFOzidSYXL4jmOFDX6mG56 QWz+17DZCk53Po8l6xyL5avkZx4pVL0uJPR4p3vVs5srvyW0ky9k4vfdI90istZZrjF6Kxsns H94e2Wt5ju9o+ntHY8wDAJx2Pr0906lJtV6JrDjsWw6K8TPUvniXUnneDCDNezUqV1Qa2PSBe Lt8djxWfpGKPhf49w1LXrQrjpe2zYCkV04HvmSo2wZxFOB4njQrIJMK+QtMocETWprqtwWGrQ pLLAhg5HkELRk50IKYPA2cqK4g8QSkMmZXy/EY63xgtb6yjF/mmab+P3zGxqoaATLzyH0Ow5t EvO590Aru4a1OKnZ4FeN8j8EErdbzMJTVZKJYqlwJHhFiQHp2njn0QMgEYG6rrt+oiZI7vPLC 2j7VO48IANroMxfzseLc0bwvYD7XqHmeP1p7f3RE6+B/7iarR0GsWdS+97UOfb5DH6e/ULLfu zsWiZUk Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sat, 20 Aug 2016 21:25:20 +0200 Six local variables will be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/scsi/aacraid/commctrl.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c index 6dcdf91..49a664f 100644 --- a/drivers/scsi/aacraid/commctrl.c +++ b/drivers/scsi/aacraid/commctrl.c @@ -476,20 +476,20 @@ static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg) { struct fib* srbfib; int status; - struct aac_srb *srbcmd = NULL; - struct user_aac_srb *user_srbcmd = NULL; + struct aac_srb *srbcmd; + struct user_aac_srb *user_srbcmd; struct user_aac_srb __user *user_srb = arg; struct aac_srb_reply __user *user_reply; struct aac_srb_reply* reply; - u32 fibsize = 0; - u32 flags = 0; + u32 fibsize; + u32 flags; s32 rcode = 0; u32 data_dir; void __user *sg_user[32]; void *sg_list[32]; u32 sg_indx = 0; - u32 byte_count = 0; - u32 actual_fibsize64, actual_fibsize = 0; + u32 byte_count; + u32 actual_fibsize64, actual_fibsize; int i;