From patchwork Mon Oct 12 15:10:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7376371 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DA29DBEEA4 for ; Mon, 12 Oct 2015 15:10:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1735E208E5 for ; Mon, 12 Oct 2015 15:10:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A75B208E7 for ; Mon, 12 Oct 2015 15:10:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751608AbbJLPKX (ORCPT ); Mon, 12 Oct 2015 11:10:23 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:64108 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751231AbbJLPKW (ORCPT ); Mon, 12 Oct 2015 11:10:22 -0400 Received: from wuerfel.localnet ([149.172.15.242]) by mrelayeu.kundenserver.de (mreue103) with ESMTPSA (Nemesis) id 0Lf0KF-1aNEPt3zn5-00qjAy; Mon, 12 Oct 2015 17:10:19 +0200 From: Arnd Bergmann To: linux-scsi@vger.kernel.org, JBottomley@odin.com Cc: Hannes Reinecke , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: advansys needs ISA dma api for ISA support Date: Mon, 12 Oct 2015 17:10:16 +0200 Message-ID: <5081546.QjQ32dGX2L@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:yuwCsi/ff3KZmoSlsV56qEQTGNO4pjPKKjYjPS1Wf3PEQOvKF1w YHn0yya79W7VZ5T+zObpYc5oM/AIVQlvWlEeBJz/tYI+mZsnOnZFZEwDeThV9cRAircvei2 0O08NPc/w60yXB2+RnFp4STX/gMX/ISOdihnVVA/kH+7A2xOOtvfxtteoR8vyHAHe2JIZ0i k0sdUSe622QbFjckctb4A== X-UI-Out-Filterresults: notjunk:1; V01:K0:3+hrBSgPOB4=:M449YFtzPMDNh2ciy7Zh8o th5eX0gwUyf6fdWyqetSPd8iHW4kY5q1S2XNsOYgurkD90VA9zF3ZYKVKRYYSZvi3D5iPFjH9 vmYJ7DAJhtdOO6Fk7N3MrVYLsEdJX+N2T08M95gZ9MMNbcpqnngy+JqMRBWog2fq09ACc9CR1 nmUww9xvb31U9FiS0/qKknqLbxh57/A6MUluaejEBjjXXK7hoawDnu8zb4ZaM3622wcvyd9gI 0zohrw/oscXg09qTwHbhDC+vXVShd9CpiLlXFe9G/iuWCs8gl062tHzjBDOiCqh4ffGtIp5xn /G9cX8XtR/GvX74eZGlclhAb6BH1k0UxdH1mlbHacu5xPumrGeg4abCepLIw4aIjoCHbpOil9 PPPHPvBXf10DTVd7qCHAKJ2f6t6P/NsBkJ69yaoMP0wanC/avlvxG6g1sOXNs0DWu5mwrCf+7 qcqJKk776ez5Raq3WiZaHFniKLvlxQlobdxbwyhbYTQZj5A72McDLYwCqVoFdOnWmtgHLT768 3X6YSR4JzWpuDph2uphc/4SrTPIL9qQsyiNX6akr8G63JOjOuCsPjPtIQ79HsF/L0HJKlLTN+ o+ZdqyDqcKPWldrUIPuaRyk1e+/Eg0Bx+MPbsJgVEyYMW4Lq9qSb11PBEsLvemiR/ZjoJ4buU inWoVdGsrBaEzksK20IUgYYxdiUN1sk2BNHqBaHwI7B85vjE0M7IYBLw2HKwRiXjWUsws4WOx Q0zuRWyEqp72VWwD Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The advansys drvier uses the request_dma function that is used on ISA machines for the internal DMA controller, which causes build errors on platforms that have ISA slots but do not provide the ISA DMA API: drivers/scsi/advansys.c: In function 'advansys_board_found': drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration] The problem now showed up in ARM randconfig builds after commit 6571fb3f8b7f ("advansys: Update to version 3.5 and remove compilation warning") made it possible to build on platforms that have neither VIRT_TO_BUS nor ISA_DMA_API but that do have ISA. This adds the missing dependency. Signed-off-by: Arnd Bergmann Reviewed-by: Hannes Reinecke --- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index d2f480b04a52..d4aa6a1a806c 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -499,6 +499,7 @@ config SCSI_ADVANSYS tristate "AdvanSys SCSI support" depends on SCSI depends on ISA || EISA || PCI + depends on ISA_DMA_API || !ISA help This is a driver for all SCSI host adapters manufactured by AdvanSys. It is documented in the kernel source in