diff mbox

[6/9] lpfc: Fix cq_id masking problem.

Message ID 555f4060.Uu2ZGqqAXkqDGUog%james.smart@avagotech.com (mailing list archive)
State New, archived
Headers show

Commit Message

James Smart May 22, 2015, 2:42 p.m. UTC 
Fix cq_id masking problem.

The driver inadvertainly constrained the id space to 8 bits, when its
a full 16 bits from hw. This resulted in bad id's being written to the
hardware. Resulted in symptoms such as incomplete initialization, no
detection of link events, etc.

Signed-off-by: Dick Kennedy <dick.kennedy@avagotech.com>
Signed-off-by: James Smart <james.smart@avagotech.com>
---
 drivers/scsi/lpfc/lpfc_hw4.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sebastian Herbszt May 24, 2015, 8:24 p.m. UTC | #1 
James Smart wrote:
> 
> Fix cq_id masking problem.
> 
> The driver inadvertainly constrained the id space to 8 bits, when its

inadvertently, it's

> a full 16 bits from hw. This resulted in bad id's being written to the
> hardware. Resulted in symptoms such as incomplete initialization, no
> detection of link events, etc.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Hannes Reinecke May 25, 2015, 3:19 p.m. UTC | #2 
On 05/22/2015 04:42 PM, James Smart wrote:
> 
> Fix cq_id masking problem.
> 
> The driver inadvertainly constrained the id space to 8 bits, when its
> a full 16 bits from hw. This resulted in bad id's being written to the
> hardware. Resulted in symptoms such as incomplete initialization, no
> detection of link events, etc.
> 
> Signed-off-by: Dick Kennedy <dick.kennedy@avagotech.com>
> Signed-off-by: James Smart <james.smart@avagotech.com>
> ---
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
diff mbox

Patch

diff --git a/drivers/scsi/lpfc/lpfc_hw4.h b/drivers/scsi/lpfc/lpfc_hw4.h
index b94fa46..33ec4fa 100644
--- a/drivers/scsi/lpfc/lpfc_hw4.h
+++ b/drivers/scsi/lpfc/lpfc_hw4.h
@@ -291,7 +291,7 @@  struct sli4_bls_rsp {
 struct lpfc_eqe {
 	uint32_t word0;
 #define lpfc_eqe_resource_id_SHIFT	16
-#define lpfc_eqe_resource_id_MASK	0x000000FF
+#define lpfc_eqe_resource_id_MASK	0x0000FFFF
 #define lpfc_eqe_resource_id_WORD	word0
 #define lpfc_eqe_minor_code_SHIFT	4
 #define lpfc_eqe_minor_code_MASK	0x00000FFF