From patchwork Thu Jun 4 22:55:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 6550451 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 572D19F3D1 for ; Thu, 4 Jun 2015 22:55:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5D9FC2071B for ; Thu, 4 Jun 2015 22:55:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 643DA2071E for ; Thu, 4 Jun 2015 22:55:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932325AbbFDWzQ (ORCPT ); Thu, 4 Jun 2015 18:55:16 -0400 Received: from mail-bl2on0072.outbound.protection.outlook.com ([65.55.169.72]:61568 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932316AbbFDWzP (ORCPT ); Thu, 4 Jun 2015 18:55:15 -0400 Received: from BY2PR02CA0089.namprd02.prod.outlook.com (10.242.32.47) by CY1PR0201MB1034.namprd02.prod.outlook.com (25.161.211.152) with Microsoft SMTP Server (TLS) id 15.1.172.22; Thu, 4 Jun 2015 22:55:12 +0000 Received: from BL2FFO11FD026.protection.gbl (2a01:111:f400:7c09::189) by BY2PR02CA0089.outlook.office365.com (2a01:111:e400:2c2a::47) with Microsoft SMTP Server (TLS) id 15.1.184.17 via Frontend Transport; Thu, 4 Jun 2015 22:55:06 +0000 Authentication-Results: spf=pass (sender IP is 63.163.107.173) smtp.mailfrom=sandisk.com; qlogic.com; dkim=none (message not signed) header.d=none; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 63.163.107.173 as permitted sender) receiver=protection.outlook.com; client-ip=63.163.107.173; helo=milsmgep12.sandisk.com; Received: from milsmgep12.sandisk.com (63.163.107.173) by BL2FFO11FD026.mail.protection.outlook.com (10.173.161.105) with Microsoft SMTP Server id 15.1.184.11 via Frontend Transport; Thu, 4 Jun 2015 22:55:05 +0000 Received: from MILHUBIP04.sdcorp.global.sandisk.com ( [172.22.12.162]) by milsmgep12.sandisk.com (Symantec Messaging Gateway) with SMTP id B5.41.06265.947D0755; Thu, 4 Jun 2015 15:55:05 -0700 (PDT) Received: from milsmgip11.sandisk.com (10.177.8.100) by MILHUBIP04.sdcorp.global.sandisk.com (10.177.9.97) with Microsoft SMTP Server id 14.3.224.2; Thu, 4 Jun 2015 15:55:05 -0700 X-AuditID: ac160a69-f790f6d000001879-d7-5570d749736d Received: from exp-402881.sandisk.com ( [10.177.8.100]) by milsmgip11.sandisk.com (Symantec Messaging Gateway) with SMTP id A7.2A.03643.847D0755; Thu, 4 Jun 2015 15:55:05 -0700 (PDT) Message-ID: <5570D748.4040504@sandisk.com> Date: Thu, 4 Jun 2015 15:55:04 -0700 From: Bart Van Assche User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: James Bottomley CC: Himanshu Madhani , Quinn Tran , Saurav Kashyap , "linux-scsi@vger.kernel.org" Subject: [PATCH 05/10] qla2xxx: Specify the [noderef] attribute once References: <5570D656.9050704@sandisk.com> In-Reply-To: <5570D656.9050704@sandisk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGLMWRmVeSWpSXmKPExsWyRoxnka7n9YJQg/ULlSxe/HjCavF//W0W i+7rO9gsrt14y2wxf+ZfVgdWj8M/fjB7rPtygt3j8ya5AOYoLpuU1JzMstQifbsErowtb46w FcwRqjh/ZQNbA+N+/i5GTg4JAROJbZe+M0PYYhIX7q1n62Lk4hASOMEoceXAI0YIZzujxKmT j5hgOv5Nfs0CkdjNKHFgRReQw8HBK6Al8WZPGkgNi4CKRHtDLxuIzSZgJPHt/UywElGBMIk9 e1RBwrwCghInZz5hAbFFBDQlriydCzaeWeAgo8SvD+kgtrCAi8SMrmlMIK1CQNMnHFQGCXMK aEv8/nSeGSTMDNS6fpc+RKe8xPa3c5hBDpMQ2MsqcWzvZ7CRQgLqEieXzGeawCgyC8nmWQjt s5C0L2BkXsUolpuZU5ybnlpgaKRXnJiXklmcrZecn7uJERwbXJk7GFdMMj/EKMDBqMTDa3Es P1SINbGsuDL3EKMEB7OSCO/cTQWhQrwpiZVVqUX58UWlOanFhxilOViUxHl7c3VChQTSE0tS s1NTC1KLYLJMHJxSDYyzOt5dXcH9/i2X0BPPa0y7X12bPY1x72OWjxcvdvqf4C0yWndQLyrj znbtXxHua7es+7XA8tGpzyvt7ZWvLHf3y9u+IP/yM2MmfePpTzmX303geTkp+zG3yadjC1QM JlxyWaW7wc33pfOjR9Z9374+f5aS5pq7PTtW+KRUz733D5rqBHW7twjZKrEUZyQaajEXFScC AFWNZRmJAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLJMWRmVeSWpSXmKPExsXCtZEjRdfzekGoweF2CYsXP56wWvxff5vF ovv6DjaLazfeMlvMn/mX1YHV4/CPH8we676cYPf4vEkugDmKyyYlNSezLLVI3y6BK2PLmyNs BXOEKs5f2cDWwLifv4uRk0NCwETi3+TXLBC2mMSFe+vZuhi5OIQEdjJKvNl7hrWLkYODV0BL 4s2eNBCTRUBVYs9HZpByNgEjiW/vZ7KAhEUFwiT27FEFCfMKCEqcnPkEbKKIgKbElaVzmUAm MgscZZSYtLyBFSQhLOAiMaNrGhNIrxDQ9AkHlUHCnALaEr8/nQcbzyygLvFn3iUoW15i+9s5 zBMY+WchWTELSdksJGULGJlXMYrlZuYU56ZnFhga6hUn5qVkFmfrJefnbmIEByhn5A7GpxPN DzEycXBKNTBeFEyZ/aWz79W/7U2TQm4zdpxbPPnWTXupPZ9efJ/AnxsX8OnY2T9mGr1yDaVJ US77n76z5JrH1XNTx/7oA4nMW9HnHl/WtfWvnlHGlxZyX6FX6xfHQZ5G6+JF9yVXTzqednxi BPP8J3oVl/1tpE5Oe/BBa+6z/5zfzBk/BG8w5Ta9llx14jKvEktxRqKhFnNRcSIAT8/9bQAC AAA= X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD026; 1:5NkGmHcPwHXWrevfX4100WgF+4nOvravSRWvTaodpArli3eu/B6rkiJJfa7kFQI3tqn4/xFLv3JUUhg4pjDPGwv853agFAKnb3d+CJCufgdQR7EQGiuQFtWN9/J0uq85/PO0BFOrGPkVnsaQGuat2hdXdYg2ms7SYwjhiqsetgTfRGLTnXyt7FKXxkk0IIwv3PgNFfQsQiZ4rzDFT97/xOTM3HLQIjkqRmybBHu4wVM5uiKw4CkPAMy79BzlQcbUuYC0hCzNGrLPX6zWiptlJRHiNVYNm+MnMP63CpL4Bnm8zvxjk3wWuB5L4QOSdASivPAoLsEx1YXn7WsD8/i3vg== X-Forefront-Antispam-Report: CIP:63.163.107.173; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(438002)(189002)(199003)(86362001)(4001350100001)(54356999)(46102003)(83506001)(36756003)(189998001)(229853001)(19580395003)(92566002)(87936001)(50986999)(19580405001)(47776003)(53416004)(77096005)(106466001)(65806001)(65956001)(575784001)(50466002)(110136002)(5001960100002)(2950100001)(87266999)(65816999)(76176999)(23676002)(62966003)(64126003)(77156002)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0201MB1034; H:milsmgep12.sandisk.com; FPR:; SPF:Pass; MLV:sfv; MX:1; A:1; LANG:; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0201MB1034; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(520003)(3002001); SRVR:CY1PR0201MB1034; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0201MB1034; X-Forefront-PRVS: 0597911EE1 X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2015 22:55:05.5701 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d; Ip=[63.163.107.173]; Helo=[milsmgep12.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB1034 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch avoids that sparse complains about duplicate [noderef] attributes. Signed-off-by: Bart Van Assche Acked-by: Himanshu Madhani Cc: Quinn Tran Cc: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_init.c | 2 +- drivers/scsi/qla2xxx/qla_iocb.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c index 3a786e4..1a1a221 100644 --- a/drivers/scsi/qla2xxx/qla_dbg.c +++ b/drivers/scsi/qla2xxx/qla_dbg.c @@ -627,7 +627,7 @@ qla25xx_copy_mq(struct qla_hw_data *ha, void *ptr, uint32_t **last_chain) uint32_t cnt, que_idx; uint8_t que_cnt; struct qla2xxx_mq_chain *mq = ptr; - device_reg_t __iomem *reg; + device_reg_t *reg; if (!ha->mqenable || IS_QLA83XX(ha) || IS_QLA27XX(ha)) return ptr; diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 98f89a5..33cb3f6 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -2085,7 +2085,7 @@ void qla24xx_config_rings(struct scsi_qla_host *vha) { struct qla_hw_data *ha = vha->hw; - device_reg_t __iomem *reg = ISP_QUE_REG(ha, 0); + device_reg_t *reg = ISP_QUE_REG(ha, 0); struct device_reg_2xxx __iomem *ioreg = &ha->iobase->isp; struct qla_msix_entry *msix; struct init_cb_24xx *icb; diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 3ac0e41..25f31d9 100644 --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c @@ -451,7 +451,7 @@ void qla2x00_start_iocbs(struct scsi_qla_host *vha, struct req_que *req) { struct qla_hw_data *ha = vha->hw; - device_reg_t __iomem *reg = ISP_QUE_REG(ha, req->id); + device_reg_t *reg = ISP_QUE_REG(ha, req->id); if (IS_P3P_TYPE(ha)) { qla82xx_start_iocbs(vha); @@ -1795,7 +1795,7 @@ qla2x00_alloc_iocbs(scsi_qla_host_t *vha, srb_t *sp) { struct qla_hw_data *ha = vha->hw; struct req_que *req = ha->req_q_map[0]; - device_reg_t __iomem *reg = ISP_QUE_REG(ha, req->id); + device_reg_t *reg = ISP_QUE_REG(ha, req->id); uint32_t index, handle; request_t *pkt; uint16_t cnt, req_cnt;