From patchwork Thu Jun 4 22:56:03 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 6550471 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0964F9F3D1 for ; Thu, 4 Jun 2015 22:56:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0D33D2071E for ; Thu, 4 Jun 2015 22:56:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C3152071B for ; Thu, 4 Jun 2015 22:56:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752983AbbFDW4L (ORCPT ); Thu, 4 Jun 2015 18:56:11 -0400 Received: from mail-bn1on0091.outbound.protection.outlook.com ([157.56.110.91]:34518 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752616AbbFDW4K (ORCPT ); Thu, 4 Jun 2015 18:56:10 -0400 Received: from BLUPR02CA042.namprd02.prod.outlook.com (25.160.23.160) by CY1PR0201MB1547.namprd02.prod.outlook.com (25.163.139.26) with Microsoft SMTP Server (TLS) id 15.1.172.22; Thu, 4 Jun 2015 22:56:07 +0000 Received: from BY2FFO11FD049.protection.gbl (2a01:111:f400:7c0c::161) by BLUPR02CA042.outlook.office365.com (2a01:111:e400:8ad::32) with Microsoft SMTP Server (TLS) id 15.1.184.17 via Frontend Transport; Thu, 4 Jun 2015 22:56:07 +0000 Authentication-Results: spf=pass (sender IP is 63.163.107.173) smtp.mailfrom=sandisk.com; qlogic.com; dkim=none (message not signed) header.d=none; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 63.163.107.173 as permitted sender) receiver=protection.outlook.com; client-ip=63.163.107.173; helo=milsmgep12.sandisk.com; Received: from milsmgep12.sandisk.com (63.163.107.173) by BY2FFO11FD049.mail.protection.outlook.com (10.1.15.186) with Microsoft SMTP Server id 15.1.184.11 via Frontend Transport; Thu, 4 Jun 2015 22:56:05 +0000 Received: from MILHUBIP04.sdcorp.global.sandisk.com ( [172.22.12.162]) by milsmgep12.sandisk.com (Symantec Messaging Gateway) with SMTP id 76.41.06265.487D0755; Thu, 4 Jun 2015 15:56:04 -0700 (PDT) Received: from milsmgip11.sandisk.com (10.177.8.100) by MILHUBIP04.sdcorp.global.sandisk.com (10.177.9.97) with Microsoft SMTP Server id 14.3.224.2; Thu, 4 Jun 2015 15:56:04 -0700 X-AuditID: ac160a69-f790f6d000001879-e4-5570d784fe24 Received: from exp-402881.sandisk.com ( [10.177.8.100]) by milsmgip11.sandisk.com (Symantec Messaging Gateway) with SMTP id CD.2A.03643.387D0755; Thu, 4 Jun 2015 15:56:04 -0700 (PDT) Message-ID: <5570D783.5020601@sandisk.com> Date: Thu, 4 Jun 2015 15:56:03 -0700 From: Bart Van Assche User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: James Bottomley CC: Himanshu Madhani , Quinn Tran , Saurav Kashyap , "linux-scsi@vger.kernel.org" Subject: [PATCH 07/10] qla2xxx: Remove a superfluous test References: <5570D656.9050704@sandisk.com> In-Reply-To: <5570D656.9050704@sandisk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGLMWRmVeSWpSXmKPExsWyRoxnkW7L9YJQg5s3DSxe/HjCavF//W0W i+7rO9gsrt14y2wxf+ZfVgdWj8M/fjB7rPtygt3j8ya5AOYoLpuU1JzMstQifbsErozrR0+x FcznqDhxeQ9LA2MvexcjJ4eEgInExFevmCBsMYkL99azdTFycQgJnGCUWHlrHjuEs51RovVf E1zH92WLmSESuxklWu5OA0pwcPAKaEl0rpAAqWERUJG4cfEB2FQ2ASOJb+9nsoCUiAqESezZ owoS5hUQlDg58wkLiC0ioClxZelcsHJmgYOMEr8+pIPYwgKWEmd2v2UGaRUCmj7hoDJImFNA W+L3p/NgYWag1vW79CE65SW2v50DdpiEwF5Wie69h8DGCwmoS5xcMp9pAqPILCSbZyG0z0LS voCReRWjWG5mTnFuemqBoZFecWJeSmZxtl5yfu4mRnBscGXuYFwxyfwQowAHoxIPr8Wx/FAh 1sSy4srcQ4wSHMxKIrxzNxWECvGmJFZWpRblxxeV5qQWH2KU5mBREuftzdUJFRJITyxJzU5N LUgtgskycXBKNTAWrH2TOKu3YmfMIwEvrx2CdSxFmxm0D7i0r1k+MXpF3e/1W3c0XNKrf5Y4 f84F+wCjbKPtTUe9113d9146omjl5i9bSiZ/WJmS++bQposvf25vWPou65n16WgmodATL8Nm zje90sHZ/PuQrHab/HeL/THzyxdl7KjRmc5sV7zndW7o470dVdeklFiKMxINtZiLihMBsLlo S4kCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHJMWRmVeSWpSXmKPExsXCtZEjRbflekGowZ1FihYvfjxhtfi//jaL Rff1HWwW1268ZbaYP/MvqwOrx+EfP5g91n05we7xeZNcAHMUl01Kak5mWWqRvl0CV8b1o6fY CuZzVJy4vIelgbGXvYuRk0NCwETi+7LFzBC2mMSFe+vZuhi5OIQEdjJKnFg8namLkYODV0BL onOFBEgNi4CqxIfWcywgNpuAkcS39zNZQEpEBcIk9uxRBQnzCghKnJz5BKxEREBT4srSuUwg I5kFjjJKTFrewAqSEBawlDiz+y0zSK8Q0PgJB5VBwpwC2hK/P50HO4dZQF3iz7xLULa8xPa3 c5gnMPLPQrJiFpKyWUjKFjAyr2IUy83MKc5NzywwNNQrTsxLySzO1kvOz93ECA5RzsgdjE8n mh9iZOLglGpgFNuUfHv7mq3P+A6FxOrxMZ9a/fbPvUXuweJb/6R2lfRMPan0kPkdL9cqu7B3 Rjs/Bi0vXfvW9HRYgNDKZJe34genTzK11/19K0/lZOvcQnZn7oCymbNOPxRyrm80FFi5QIHt lmz53JUhfUe2ff+YYPxozfmVrVxvr+da/MwONKndPD8mZsa9fCWW4oxEQy3mouJEAFNF59AB AgAA X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD049; 1:ZUN/ADTfU7Qd6F+ocbFbIYKIP2/sFPpefT6/QZj6iF6wDwuMbKiCWcz5xxnIYWrvewwgtlnLn3In6TD+2k1TySjbaNrIfFO/ajfhIVhLJ3PvdE/WmgAF7hzgFzHRyjkdyaOxHng4fKnv2IwigOO1hxB4rhZxD6n40yvc4ZhIixbD4fJAfqn5guNBqqf3OiX9NWzGXAo5wnQ+bGddHFmVpR+KmXJQfFAFvWaKCpbY/r615rmiVlQsXfb5HsGMA6dG58tDl7bIPgOW4/GxpK0TVM8ZH4AqwAMJyBxip+7JKR6VXxKh8XpQ3htEjegnGaoq X-Forefront-Antispam-Report: CIP:63.163.107.173; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(438002)(199003)(189002)(229853001)(76176999)(4001350100001)(64126003)(65816999)(23676002)(86362001)(50986999)(54356999)(53416004)(65956001)(36756003)(110136002)(2950100001)(19580395003)(92566002)(83506001)(33656002)(19580405001)(50466002)(77096005)(62966003)(87936001)(46102003)(77156002)(5001960100002)(106466001)(47776003)(87266999)(189998001)(65806001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0201MB1547; H:milsmgep12.sandisk.com; FPR:; SPF:Pass; MLV:sfv; A:1; MX:1; LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0201MB1547; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(520003)(5005006)(3002001); SRVR:CY1PR0201MB1547; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0201MB1547; X-Forefront-PRVS: 0597911EE1 X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2015 22:56:05.0857 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d; Ip=[63.163.107.173]; Helo=[milsmgep12.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB1547 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Avoid that smatch reports the following warning: drivers/scsi/qla2xxx/qla_attr.c:1081: qla2x00_model_desc_show() warn: this array is probably non-NULL. 'vha->hw->model_desc' Signed-off-by: Bart Van Assche Acked-by: Himanshu Madhani Cc: Quinn Tran Cc: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_attr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c index 741d6e0..2087b73 100644 --- a/drivers/scsi/qla2xxx/qla_attr.c +++ b/drivers/scsi/qla2xxx/qla_attr.c @@ -1077,8 +1077,7 @@ qla2x00_model_desc_show(struct device *dev, struct device_attribute *attr, char *buf) { scsi_qla_host_t *vha = shost_priv(class_to_shost(dev)); - return scnprintf(buf, PAGE_SIZE, "%s\n", - vha->hw->model_desc ? vha->hw->model_desc : ""); + return scnprintf(buf, PAGE_SIZE, "%s\n", vha->hw->model_desc); } static ssize_t