From patchwork Wed Jun 24 15:33:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 6668921 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 299F2C05AC for ; Wed, 24 Jun 2015 15:34:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1F96C2057F for ; Wed, 24 Jun 2015 15:34:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 267332057E for ; Wed, 24 Jun 2015 15:33:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753223AbbFXPd6 (ORCPT ); Wed, 24 Jun 2015 11:33:58 -0400 Received: from mout.web.de ([212.227.15.4]:64776 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752756AbbFXPd4 (ORCPT ); Wed, 24 Jun 2015 11:33:56 -0400 Received: from [192.168.1.3] ([78.49.141.189]) by smtp.web.de (mrweb004) with ESMTPSA (Nemesis) id 0Md16Y-1ZOlZS3oyA-00IFZY; Wed, 24 Jun 2015 17:33:53 +0200 Message-ID: <558ACDDE.5090403@users.sourceforge.net> Date: Wed, 24 Jun 2015 17:33:50 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "James E. J. Bottomley" , linux-scsi@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] SCSI-wd33c93: Deletion of a check before the function call "wd33c93_setup" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> X-Provags-ID: V03:K0:eTKtReLhHH2Z+X0bKBOGw9/zprWBkoNjpXkpIA0dKKlo+y/0HFB 2DI7AKk4KIPFU87mF+R20a1idmu0dY6Loomd6ZCoezTPlSOvjkCB5JBLCLcmQobSiVznePM kxrQNYacNfJSc4keOr/KKmVWnVE3DVgbx7eFTo2la4lq4iCE3m7VvXvYpcM6zIKEZ9hPXsI c6d2O8AYkpUUaaOiP8zHw== X-UI-Out-Filterresults: notjunk:1; V01:K0:B9pxL1nXihE=:rnbsnp3pQRSGucLOsmfD8P Le6/fep3QeBtrAEVZ5CpBP0z6+JdR5646y2JKq5HnIEfKmoPZ3AzwbSuf9hRwAMxrPgtFF07M yMIDuUCbP09inWz9hMrD+f/71giyelbUdR0JjZM8iHd/vZkdDnqvDf0nS7LT6WculAJ+woa5P KErlhRgDLdfsMMYZnz4/u+RvwujGb+LORnyft9J6NDkX7VTAfpMWZVp7OOveuUbGdcChAQgbG UZq+ApFdOqv/+wAqNHNsPVwtbBhYxErUmCaZCYmTyEndS9UtLl3kEq+RmECZFy9xokwRb53Ur TNkhQ3zasCVPe5go0vxtWUk7F3HYETsLBvJDxW++xikFO5GmSJ7u+jHhRyR5kXv41mtrcDVYJ iwG68PGN+iezspJx4K1vRLjRp03RfDdKZENZfkp3N59lL7AhLA4TXRaT0WDfZ7iWsHGjTYuPb BRhaSH2YdtKsn84bbXZH12rY+mrFZLhYeImOtWjgtybQQCD8OuqJ2tqK3+rrLEaRUFv35mVnp dueGSvqTCM/smtWd6sF7bZiZ5F3kgHWYc7+BCC5jitQBuhyDjYteyl2CMNhQpUM/RZgoyfH8s G7ayMtGVb8jWhFVvVMKIC65L3ZGpBi6MCZibm897IsZwtqI4J1AlVSrhjzvIkz6zB6YjdFPJc h+QR3FEvqFulxeqfBpt6vMCmH6Nws18gsndpZjO8mmMIfIGwnY8kP+ZVMY98i0lok5TE= Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Wed, 24 Jun 2015 17:15:17 +0200 The wd33c93_setup() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/scsi/wd33c93.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/wd33c93.c b/drivers/scsi/wd33c93.c index 9e09da4..e5ed956 100644 --- a/drivers/scsi/wd33c93.c +++ b/drivers/scsi/wd33c93.c @@ -1939,7 +1939,7 @@ wd33c93_init(struct Scsi_Host *instance, const wd33c93_regs regs, int val; char buf[32]; - if (!done_setup && setup_strings) + if (!done_setup) wd33c93_setup(setup_strings); hostdata = (struct WD33C93_hostdata *) instance->hostdata;