From patchwork Thu Jul 9 14:25:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 6756471 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DB18DC05AC for ; Thu, 9 Jul 2015 14:25:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F192A205EE for ; Thu, 9 Jul 2015 14:25:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0FB0D205EB for ; Thu, 9 Jul 2015 14:25:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751754AbbGIOZP (ORCPT ); Thu, 9 Jul 2015 10:25:15 -0400 Received: from mail-bn1on0057.outbound.protection.outlook.com ([157.56.110.57]:56352 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750894AbbGIOZN (ORCPT ); Thu, 9 Jul 2015 10:25:13 -0400 Received: from BY2PR02CA0036.namprd02.prod.outlook.com (10.141.216.26) by BN3PR02MB1256.namprd02.prod.outlook.com (10.163.34.14) with Microsoft SMTP Server (TLS) id 15.1.207.19; Thu, 9 Jul 2015 14:25:11 +0000 Received: from BL2FFO11FD047.protection.gbl (2a01:111:f400:7c09::105) by BY2PR02CA0036.outlook.office365.com (2a01:111:e400:2c40::26) with Microsoft SMTP Server (TLS) id 15.1.213.14 via Frontend Transport; Thu, 9 Jul 2015 14:25:11 +0000 Authentication-Results: spf=pass (sender IP is 63.163.107.173) smtp.mailfrom=sandisk.com; qlogic.com; dkim=none (message not signed) header.d=none; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 63.163.107.173 as permitted sender) receiver=protection.outlook.com; client-ip=63.163.107.173; helo=milsmgep12.sandisk.com; Received: from milsmgep12.sandisk.com (63.163.107.173) by BL2FFO11FD047.mail.protection.outlook.com (10.173.161.209) with Microsoft SMTP Server id 15.1.190.9 via Frontend Transport; Thu, 9 Jul 2015 14:25:08 +0000 Received: from MILHUBIP03.sdcorp.global.sandisk.com ( [172.22.12.162]) by milsmgep12.sandisk.com (Symantec Messaging Gateway) with SMTP id 31.2A.06265.4448E955; Thu, 9 Jul 2015 07:25:08 -0700 (PDT) Received: from milsmgip12.sandisk.com (10.177.8.100) by MILHUBIP03.sdcorp.global.sandisk.com (10.177.9.96) with Microsoft SMTP Server id 14.3.224.2; Thu, 9 Jul 2015 07:25:08 -0700 X-AuditID: ac160a69-f790f6d000001879-9d-559e84441dd9 Received: from [10.50.231.57] ( [10.177.8.100]) by milsmgip12.sandisk.com (Symantec Messaging Gateway) with SMTP id 60.5D.04661.3448E955; Thu, 9 Jul 2015 07:25:08 -0700 (PDT) Message-ID: <559E8443.8010002@sandisk.com> Date: Thu, 9 Jul 2015 07:25:07 -0700 From: Bart Van Assche User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: James Bottomley CC: Himanshu Madhani , Quinn Tran , Saurav Kashyap , "linux-scsi@vger.kernel.org" Subject: [PATCH v3 08/10] qla2xxx: Remove a superfluous test References: <559E8382.6030803@sandisk.com> In-Reply-To: <559E8382.6030803@sandisk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsWyRoxnka5Ly7xQg5fvVS1e/HjCavF//W0W i+7rO9gsrt14y2wxf+ZfVgdWj8M/fjB7rPtygt3j8ya5AOYoLpuU1JzMstQifbsErozrR0+x FcznqDhxeQ9LA2MvexcjJ4eEgInE7K4HTBC2mMSFe+vZuhi5OIQETjBKbLjzjhUkISSwnVHi 619ZmIZNs98yQRRtZpS4s/ADM0iCV0BLon3rHxYQm0VARaJ/5TmwOJuAkcS39zOB4hwcogJh Env2qEKUC0qcnPkErFxEQFPiytK5YEcwCxxklPj1IR3EFhawkfg4q4ER4gYtiWMTZ4LVcwpo S7yZvIgNZCQzUO/6XfoQrfIS29/OYQY5TUJgG6vE3r2tUL3qEieXzGeawCgyC8nqWQjts5C0 L2BkXsUolpuZU5ybnlpgaKRXnJiXklmcrZecn7uJERwdXJk7GFdMMj/EKMDBqMTD27BzbqgQ a2JZcWXuIUYJDmYlEV49z3mhQrwpiZVVqUX58UWlOanFhxilOViUxHl7c3VChQTSE0tSs1NT C1KLYLJMHJxSDYxT3/y7uvGgjlbvAa05nvYHZXJuF96b7rjud3Dk8oIQ79XvXyYfZNznqiuW umXbE7/F7FPvi8TlXBTJj+O6x75UJ4XpbJHDk4Tiq7pOdt8fzBK6d3Olru8b1mWhYT5h1jNv L+tM4U8oE5pmLfDt7C8dRsaDxi/ucm3vWctRvuXvmvNyx2S2r5ZTYinOSDTUYi4qTgQAWS0A yYoCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrAJMWRmVeSWpSXmKPExsXCtZEjRdelZV6owaJr0hYvfjxhtfi//jaL Rff1HWwW1268ZbaYP/MvqwOrx+EfP5g91n05we7xeZNcAHMUl01Kak5mWWqRvl0CV8b1o6fY CuZzVJy4vIelgbGXvYuRk0NCwERi0+y3TBC2mMSFe+vZuhi5OIQENjJK3G9vByviFdCSaN/6 hwXEZhFQlXi16DlYA5uAkcS39zOB4hwcogJhEnv2qEKUC0qcnPkErFxEQFPiytK5TCAzmQWO MkpMWt7ACpIQFrCR+DirgRHEFgKaf2ziTLAGTgFtiTeTF7GB2MwC6hJ/5l1ihrDlJba/ncM8 gZF/FpIds5CUzUJStoCReRWjWG5mTnFuemaBoZFecWJeSmZxtl5yfu4mRnCYckbtYLw+0fwQ IxMHp1QD43pTY4d1sQteTUtMtC1xrqudwPiiNNl48SrZJT+dL85ieKPSW3Joh5rpnYcrdom8 YsjYM2FmuMH160k/3T8Uph0Nfr8wcNbRZ1pH481fFywt466ZNH/Vz309Md9P5gh4/2u/+0fk 7IlPLCbB6TXlru6+904wzzfd4NbZ4x3jMuu9aA63oLL0FSWW4oxEQy3mouJEAMtSSOkDAgAA X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD047; 1:L24xAvdeb3Wkpe1cE8EkfrtnYHjojQe+D1B7DymHgo1cAlA4BHqn17IVJy521K6BUZjwZmu/w1Fpx6LZQL/D/PUXdmm82e+st3FhvUFPcnWC0B3jjKPqSXnuIEMNbPO8CxBsSN8sGiKRFuC7dKHp6SPyWoSTRiQgFS3x184056Asa5S1I0Np7hd+IbAqErjYtWDXC/BwsZMAPjCQmtP9vtSw5kBdAv8wc+GKEt/4KXBGPT92Lcex4DNSEWTItQoga7NCqFysiDcd5y4Rz8bICtT5gp0lbr2qI/4hP7g8SNAz+cRhMd5+n7q0iU5M83zi X-Forefront-Antispam-Report: CIP:63.163.107.173; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(438002)(199003)(189002)(189998001)(62966003)(110136002)(5001960100002)(77156002)(229853001)(19580405001)(4001350100001)(87936001)(80316001)(33656002)(36756003)(65956001)(86362001)(19580395003)(5001920100001)(64126003)(92566002)(23676002)(106466001)(65816999)(54356999)(87266999)(46102003)(77096005)(76176999)(50986999)(2950100001)(50466002)(83506001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR02MB1256; H:milsmgep12.sandisk.com; FPR:; SPF:Pass; MLV:sfv; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN3PR02MB1256; 2:3y4O/yF0yri8T2mj0lmwo6+M3+teQmBlnFXcF6KdHiNW8YJnPpNH8S47zbKNYCeY; 3:fXb3XXI1S1WZCZEAOhF/mJbmdd3Fp4JCk5VuAGDce1iDBix0NQkySE5GN8FSb578Ybp2jlkMkbNkkx/38x1Wib/gclZ7rb5sKAYD6N2ecEtV7jHIZ3HTJCAKhWZw9WdtsdRQutpxi+TTo4k9vyFiHkV+tP0tBWDI5pfpvco6gH1n8rB1v21dzt/cBGO7kUmy96EK9vReJDbtumkEhNlzLv/7P+IjYwa/Mf3CeoTCWLkW4UABpdA8m8nzics+SW4I; 25:p2/t/SNqhgoofMW9KYDivff7R2fNWKtZlJzjDQE/OQSxqcYscDkW8E6goaK4SmG89vA/6RbMumXLcWMyteC1VJzp83Pcg+kbQySVvbjyiv6Od+PvYPBFDJfojML/1kIvzkRXqKhYwCOKvEn4nLm/y4yGsKO90O3XPfw6PMTh2KTbXPT7LqNj4wfEjo8ZJt/0+TH4BSi3JILIXv/nFcm8esEmtkdwSW01STouclFymDL7a/PvSS4CARsuHIgpZj6H8yM8Mqr0OMZrkhjz1HvvYA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR02MB1256; X-Microsoft-Exchange-Diagnostics: 1; BN3PR02MB1256; 20:fnqgJsGy6NzUfXQT713PU8niNfA8r3FnE+hGspvKVtL8SwyOPBH0OkqaX5/Stdu9RHPtkDKB/N0L9TFXzEkObN88F/4kDg3Z6/WQVfOUxWP3f8fu0sjq7cdrHwBmuRYeqkQ8DIRYdW8NLLP/9+qZWLsnVhrcH5i2yCLiRaNKSWVtmqDLpPy7hVM/zqfWgNvUIoj76glwIzh18u3a3HItSVwo/vnUTRsE2GPE+4HjWGp9VBQMW/R0gR2RfRhCAaP5pU/xDFkS2b1rYconNHUN+BO+WoCXjj1AIy1YEGIpYPyWVhLHcueUoAobDaf0LxOJf7sH4nyYAt0WHGjh2A4wp45Y2ec5C+WP1nHYjjeM9A+vbImrJ7v2q3mA1aPaG+a/fUu+f2ls6UPQHrQiqZ16mhGdukp6IoF2Hm0TiuYDPD/FtUHggup6aqIqRxqWBWjqHXQ/gi9YswIcsjL6zaiW2L+1zJe6MXPVx6mnX2xPPYgqcGIH0uJ3dA/gnQOBhXAr; 4:DyTNAaIX7pRT9QqPjbpufvvsU/Yl+P8SOW42gsYAiBp2VBU4gn8+GB2y3GWo4Je92z4WvOJcE9YJ9Ze2L2fSdHpjn7LF/uio72iESY81le9X9Yq+R05VnSwFHqE64CmOb/V7Wx2RgzmDrW1ZoUIZQ55DtoA2iPEnYDlSopLyIPAbnyg4k2+MckMZhpHFUJIQ8ULjzqrkC2NGBdRGkOJJKrAsKL7rKjiCrD/tcK62x8j/lwr/eZpEwtv7IbWpJV2MP2cfk9Nq7A5LWO2nmH4YqUADZyKCzAkrWxIPVmPcKBM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:BN3PR02MB1256; BCL:0; PCL:0; RULEID:; SRVR:BN3PR02MB1256; X-Forefront-PRVS: 0632519F33 X-Microsoft-Exchange-Diagnostics: 1; BN3PR02MB1256; 23:t6Gwo/Ndsg3xmFhMBfhoDywWCXN444Kas3eGAB6LzT3S7k24Soig3bMC/KqLsFmsoAYWpE4qf7d0L2UzZy1UT2CSCoXe4WinQ+9Ge/wJn+FC+woaH8dez3hk/1C3vXvtYRuvF1Y0y27/JqtfqI0veSiucTi6/DYUzMlz3TqBEvRdr36qoHcJLXbHItAUcLMIEZW3I7hJcjVLLGoToLomLwamlHItcb8F5k7tNf8FjEFAyAJj4ZdLxCPg9iBybve/MumgQNSUn+QaWhlR45GyOjZwa662TipFaIFf3h6YfvsrWhMzfhB4qOQlAvVjGHRWHxZXWdG83bguglW4/qBFBj28OG51lw/0jkrF+NvbAEreh9d1X5eqGVKKQI0zKPZOrDaa9mBpNvCU4stZ17nzXTfpT9gUhv56pfU2Gv1h+iEiMt5S35QQ2cUb4Y3wi+YDNcPRLu3m6+/AcZRtXfm+Ig2iSrrhdxGidRZ0eyAMtPSADA4PLfdV/35K3jnO8OkC0lsA5jUJ9SY+jYW4zhOX2FHX4xByGQFj7CMlhapWHrwvjVjbqT+2mOvUHsMVDxGGkhD+mEhEX91a1du6xAnHSE2N5LhlXyasb/MwvBhTqM4r4tz1udQvlXX/dOsEevb8FVpZuNKStdaG/j6sltjdnSudHJ73oth3VrJnMzkruvmB8EKAuRhDihklHfNmrFyTYws5wlyDr13Q29xOBHtLdyON8TTJHalxme+Htn7NckSS8wnrj47Bn2wRe9FgJJ7qgJ46D7g4gkR7wk+sjGTJfWkxFJxCb1Wz79gDfBmPI7MbAY+lw4jPNsPOIxn4swyyAoV4Nmf8Z1bRC+ZtILpweuP00Hh1kLfC5zycHxyX1PgcoVD5a3s+7pIHgp15DP25L9KbbXEdVROC660JlTBRVLJokq45MVcWoWPJ4r71T FS+TfZTW3aU+cbFBFDw8OJ/ X-Microsoft-Exchange-Diagnostics: 1; BN3PR02MB1256; 5:HhYIVdd033h66y4s8r7mlU5waPCsdDfP3A6rrheh4gHKLiXPX+tbjUVM/BqFTGl4TSQAOln8R5ioSge2hwcNInS64Ye+YKGVdeBZ3gCcKEevlUu3V2EbafTUlS+DDIR84fAuezUhablGzpbG7es4kA==; 24:TLtdMzuga08g35FiyM/WxU/XvWcdxUmDNqx6+5lCPTrfrbHffikjeaH1wzoAGXZ/i3u4+Kf0gf4uxPz+GcAzm0xBZLz/1JlacAFWpX02G/w=; 20:gvSDROo83VKO0EBqX2a9E9n9tnrDHq3yoIEWlRBre3/m1t+kikSm34eRt71HKrLnYuEGndplOIbzf/XJ44W09n0ZSOvBAVIm1Hg7SIhibGMFjICXJcjWHI8dIB7Rsj9zDRIcLhGJLrQMEs3XhH2xML/85/TCyVZTHNknQ0kV6v8= X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2015 14:25:08.8512 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d; Ip=[63.163.107.173]; Helo=[milsmgep12.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR02MB1256 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Avoid that smatch reports the following warning: drivers/scsi/qla2xxx/qla_attr.c:1081: qla2x00_model_desc_show() warn: this array is probably non-NULL. 'vha->hw->model_desc' Signed-off-by: Bart Van Assche Acked-by: Himanshu Madhani Cc: Quinn Tran Cc: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_attr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c index 741d6e0..2087b73 100644 --- a/drivers/scsi/qla2xxx/qla_attr.c +++ b/drivers/scsi/qla2xxx/qla_attr.c @@ -1077,8 +1077,7 @@ qla2x00_model_desc_show(struct device *dev, struct device_attribute *attr, char *buf) { scsi_qla_host_t *vha = shost_priv(class_to_shost(dev)); - return scnprintf(buf, PAGE_SIZE, "%s\n", - vha->hw->model_desc ? vha->hw->model_desc : ""); + return scnprintf(buf, PAGE_SIZE, "%s\n", vha->hw->model_desc); } static ssize_t