From patchwork Sat Dec 12 14:45:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 7835071 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B5D299F1C2 for ; Sat, 12 Dec 2015 14:45:45 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D805A203AB for ; Sat, 12 Dec 2015 14:45:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BF8C20320 for ; Sat, 12 Dec 2015 14:45:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752272AbbLLOp3 (ORCPT ); Sat, 12 Dec 2015 09:45:29 -0500 Received: from mout.web.de ([212.227.17.11]:64883 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbbLLOp2 (ORCPT ); Sat, 12 Dec 2015 09:45:28 -0500 Received: from [192.168.1.2] ([78.49.180.156]) by smtp.web.de (mrweb101) with ESMTPSA (Nemesis) id 0LbJCQ-1aWcf92ova-00kuVA; Sat, 12 Dec 2015 15:45:25 +0100 Subject: [PATCH 7/7] iscsi-target: Make two variable initialisations a bit more obvious in iscsi_check_valuelist_for_support() To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, "Nicholas A. Bellinger" References: <566ABCD9.1060404@users.sourceforge.net> <566C2F7B.6030704@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <566C3304.1090802@users.sourceforge.net> Date: Sat, 12 Dec 2015 15:45:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <566C2F7B.6030704@users.sourceforge.net> X-Provags-ID: V03:K0:6WGP1FaiBq2j4HXrDAjgsDL9vKKJioLko/tDWcZnv30oKWF/SGk AenBOXjRJS8Bpdt8bFsAymcaQfFHOjD9/WdGsKhMMphbd96mbxawduYb+eN1GUFwkLXjsWV yycxEzzypHrLjvqPxhjqQIFnyMUrwXg44svSXlFj1AMyXte+e6eXdetxU9woqQVMFAIpzIQ S+FdS1N3NbDVWJxsDNIMw== X-UI-Out-Filterresults: notjunk:1; V01:K0:2GEOtVMxPz4=:1mBWmUXbyAwLzrl2SNig/C /1Ueogf1z0E2hNvuhgqRJ33iib+ChayWv/NyNb7EM+MBYxdEDInkdrQ/m0vDMBlQCHJ4CbwIX /bMKxq9vQFFDe6Ks59kcsXwPZ/ZmQjUmv7kme3H+4BBmkz3M0XGJE74GRvoxVlswgmkpDVdC6 UATqgbuCf01dtOPKd8mMAYmrtrTJoQN2qzDi1Zkz/7Z3pzQb+m0WUyHv3Dx7bnGTWKHrwkaWa Bdx3gbmVW4MJuN24mfNlOS1PrFcIkTq58SFhsKl9S6bHtAYQjMEnIVPMcU3n5LT7vliuAh5x5 iU0R2Rx1Xlea2Zg08YBqA4CcuQswe8OxbbXG0IYFGScbGIm7zQUvyybdiEZOTynGtdh8rFBLC zqDQcMywrCOGY7SvO5hGra1I51cPua+ZpOnMTx9qYNQGdBoAHAB+S+I3IRNplDiX741u0fjzM kVAnj0KfxVLh1HLoKTyFfZtR6mE0DPqiWvN2r3i/oAq9xlM+L2PyKXLTkRZUbqC54ZTVTgW1F OVJInaR6C8fnZnKC9+vftgkQJvi3vARtOhmbl+KHGGQU+eTsOG/x7x+YETh81ovBOhdCC0nY4 ouDrmNKQSJsrdaqieTTUYdq+EkOMdnws/jnaP4Yyd29t7M/e/wDgVVcAAw6TybL6A2qsLlfT1 k3dNEAw4XyJvUnxcltsaVkQqjXNBUnuUPLdO6ePM6MrRch9MYuaiohu/a84nmS1QFX5vt6uAS FLflFJubuGi4B4GFqAlAk6uD0Muv1hkjYPR9F3RvsfS7xf/SMJk59c0AOkhl3qmGIKg+nah9c 38lPgOU Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sat, 12 Dec 2015 15:04:57 +0100 The variable "acceptor_values" and "proposer_values" were initialized by null pointers and immediately assigned values from input parameters by separate statements. Let us express the desired variable initialisations directly. Signed-off-by: Markus Elfring --- drivers/target/iscsi/iscsi_target_parameters.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_parameters.c b/drivers/target/iscsi/iscsi_target_parameters.c index 53e3345..fb6fd34 100644 --- a/drivers/target/iscsi/iscsi_target_parameters.c +++ b/drivers/target/iscsi/iscsi_target_parameters.c @@ -921,10 +921,7 @@ static char *iscsi_check_valuelist_for_support( char *value) { char *tmp1, *tmp2; - char *acceptor_values = NULL, *proposer_values = NULL; - - acceptor_values = param->value; - proposer_values = value; + char *acceptor_values = param->value, *proposer_values = value; do { if (!proposer_values)