| Message ID | 56B10D90.2010506@cs.wisc.edu (mailing list archive) |
|---|---|
| State | Deferred, archived |
| Headers | show |
Sure thing, I will test it tonight and let you know the result. Thank you Serguei -----Original Message----- From: Mike Christie [mailto:michaelc@cs.wisc.edu] Sent: Tuesday, February 02, 2016 3:12 PM To: Christoph Hellwig <hch@infradead.org> Cc: Serguei Bezverkhi (sbezverk) <sbezverk@cisco.com>; bugzilla-daemon@bugzilla.kernel.org; linux-scsi@vger.kernel.org; Hannes Reinecke <hare@suse.de> Subject: Re: [Bug 111441] New: iscsi fails to attach to targets On 02/02/2016 12:09 PM, Christoph Hellwig wrote: > On Fri, Jan 29, 2016 at 05:32:54PM -0600, Mike Christie wrote: >> Hey Christoph and Hannes, >> >> The dh/alua changes that added this: >> >> error = scsi_dh_add_device(sdev); >> if (error) { >> sdev_printk(KERN_INFO, sdev, >> "failed to add device handler: %d\n", >> error); >> return error; >> } >> >> to scsi_sysfs_add_sdev are adding a regression. >> >> 1. If that fails, then we forget to do device_del before doing the >> return. My patch in this thread added that back, so we do not see the >> sysfs oopses anymore. But..... > > Ok. > >> 2. It looks like in older kernels, we would allow misconfigured >> targets like this one to still setup devices. Do we want that old behavior back? >> Should we just ignore the return value from scsi_dh_add_device above? >> Note that in this case, it is LIO so it can be easily fixed on the >> target side by just setting it up properly. I do not think other >> targets would hit this type of issue. > > Be liberal in what you accept.. I guess we need to continue allowing > to connect to these broken targets, but a warning would be useful. > > Can you send a patch? Serguei, can you try the attached patch? Drop the other one I sent. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
HI Mike, It is working now, it spits alua related error messages but it attaches remote and local targets, so my OpenStack is back to life. Please let me know if you plan to commit this fix upstream. [ 27.579303] scsi 3:0:0:2: Direct-Access LIO-ORG san-disk-2 4.0 PQ: 0 ANSI: 5 [ 27.579797] sd 3:0:0:2: alua: supports implicit and explicit TPGS [ 27.579932] sd 3:0:0:2: [sdc] 20507809792 512-byte logical blocks: (10.4 TB/9.54 TiB) [ 27.579975] sd 3:0:0:2: alua: No target port descriptors found [ 27.579977] sd 3:0:0:2: alua: Attach failed (-22) [ 27.580640] sd 3:0:0:2: failed to add device handler: -22 [ 27.580897] sd 3:0:0:2: [sdc] Write Protect is off [ 27.580899] sd 3:0:0:2: [sdc] Mode Sense: 43 00 10 08 [ 27.580922] sd 3:0:0:2: Attached scsi generic sg3 type 0 [ 27.581041] sd 3:0:0:2: [sdc] Write cache: enabled, read cache: enabled, supports DPO and FUA [ 27.630156] sd 3:0:0:2: [sdc] Attached SCSI disk Thank you very much Serguei Serguei Bezverkhi, TECHNICAL LEADER.SERVICES Global SP Services sbezverk@cisco.com Phone: +1 416 306 7312 Mobile: +1 514 234 7374 CCIE (R&S,SP,Sec) - #9527 Cisco.com Think before you print. This email may contain confidential and privileged material for the sole use of the intended recipient. Any review, use, distribution or disclosure by others is strictly prohibited. If you are not the intended recipient (or authorized to receive for the recipient), please contact the sender by reply email and delete all copies of this message. Please click here for Company Registration Information. -----Original Message----- From: Mike Christie [mailto:michaelc@cs.wisc.edu] Sent: Tuesday, February 02, 2016 3:12 PM To: Christoph Hellwig <hch@infradead.org> Cc: Serguei Bezverkhi (sbezverk) <sbezverk@cisco.com>; bugzilla-daemon@bugzilla.kernel.org; linux-scsi@vger.kernel.org; Hannes Reinecke <hare@suse.de> Subject: Re: [Bug 111441] New: iscsi fails to attach to targets On 02/02/2016 12:09 PM, Christoph Hellwig wrote: > On Fri, Jan 29, 2016 at 05:32:54PM -0600, Mike Christie wrote: >> Hey Christoph and Hannes, >> >> The dh/alua changes that added this: >> >> error = scsi_dh_add_device(sdev); >> if (error) { >> sdev_printk(KERN_INFO, sdev, >> "failed to add device handler: %d\n", >> error); >> return error; >> } >> >> to scsi_sysfs_add_sdev are adding a regression. >> >> 1. If that fails, then we forget to do device_del before doing the >> return. My patch in this thread added that back, so we do not see the >> sysfs oopses anymore. But..... > > Ok. > >> 2. It looks like in older kernels, we would allow misconfigured >> targets like this one to still setup devices. Do we want that old behavior back? >> Should we just ignore the return value from scsi_dh_add_device above? >> Note that in this case, it is LIO so it can be easily fixed on the >> target side by just setting it up properly. I do not think other >> targets would hit this type of issue. > > Be liberal in what you accept.. I guess we need to continue allowing > to connect to these broken targets, but a warning would be useful. > > Can you send a patch? Serguei, can you try the attached patch? Drop the other one I sent. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index 21930c9..7dcc4bf 100644 --- a/drivers/scsi/scsi_sysfs.c +++ b/drivers/scsi/scsi_sysfs.c @@ -1059,9 +1059,12 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev) error = scsi_dh_add_device(sdev); if (error) { + /* + * Allow device setup to succeed. Attachment can be retried + * from userpsace or device can be still used in degraded mode. + */ sdev_printk(KERN_INFO, sdev, "failed to add device handler: %d\n", error); - return error; } device_enable_async_suspend(&sdev->sdev_dev);