diff mbox

xen-scsiback: correct return value checks on xenbus_scanf()

Message ID 577E286802000078000FBECF@prv-mh.provo.novell.com (mailing list archive)
State Superseded, archived
Headers show

Commit Message

Jan Beulich July 7, 2016, 8:01 a.m. UTC 
Only a positive return value indicates success.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
 drivers/xen/xen-scsiback.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)




--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- 4.7-rc6-xenbus_scanf.orig/drivers/xen/xen-scsiback.c
+++ 4.7-rc6-xenbus_scanf/drivers/xen/xen-scsiback.c
@@ -1071,7 +1071,7 @@  static void scsiback_do_1lun_hotplug(str
 	/* read status */
 	snprintf(state, sizeof(state), "vscsi-devs/%s/state", ent);
 	err = xenbus_scanf(XBT_NIL, dev->nodename, state, "%u", &device_state);
-	if (XENBUS_EXIST_ERR(err))
+	if (err <= 0)
 		return;
 
 	/* physical SCSI device */
@@ -1089,7 +1089,7 @@  static void scsiback_do_1lun_hotplug(str
 	snprintf(str, sizeof(str), "vscsi-devs/%s/v-dev", ent);
 	err = xenbus_scanf(XBT_NIL, dev->nodename, str, "%u:%u:%u:%u",
 			   &vir.hst, &vir.chn, &vir.tgt, &vir.lun);
-	if (XENBUS_EXIST_ERR(err)) {
+	if (err != 4) {
 		xenbus_printf(XBT_NIL, dev->nodename, state,
 			      "%d", XenbusStateClosed);
 		return;